Review Request 129945: [tellico] Drop search for obsolete Libkcddb, don't be quiet about KF5Cddb

Robby Stephenson robby at periapsis.org
Sun Feb 12 21:29:20 UTC 2017



> On Feb. 12, 2017, 8:17 p.m., Robby Stephenson wrote:
> > I'm not sure about removing the support for using libkcddb from KF5 releases prior to 16.12. Are we really expecting users to upgrade that quickly? I still want people who compile Tellico against releases older than 16.12 to be able to use the libkcddb interface.
> > 
> > I'm ok taking out the QUIET though.
> 
> Andreas Sturmlechner wrote:
>     The point is, there was no KF5-based release prior to 16.12.0. Can you actually do anything with kdelibs4-based libkcddb?

Ah indeed, thank you for pointing that out. I'd forgotten that. In that case, please commit.


- Robby


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129945/#review102515
-----------------------------------------------------------


On Feb. 12, 2017, 7:12 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129945/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2017, 7:12 p.m.)
> 
> 
> Review request for Tellico.
> 
> 
> Repository: tellico
> 
> 
> Description
> -------
> 
> KF5-based releases are found by KF5Cddb since 16.12.0.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2b286cfd2ad5f3aa26c2c6b075d618dd9b3e4cde 
> 
> Diff: https://git.reviewboard.kde.org/r/129945/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/tellico-users/attachments/20170212/87f27039/attachment-0001.html>


More information about the tellico-users mailing list