[Tellico-users] Review Request 126705: Fix for bug #357799: [Internet Search] Result list is not cleared on new search

Robby Stephenson robby at periapsis.org
Sat Jan 16 04:18:43 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126705/#review91171
-----------------------------------------------------------



Thinking about it more, I'm coming more to your side. I'm always hesitant to add more config options, unless they're really needed. Perhaps your initial patch _is_ more intuitive and expected. Actually, yes, I'll apply your original patch to the master branch and see if anyone notices. :)

- Robby Stephenson


On Jan. 10, 2016, 7:20 p.m., Sven Werlen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126705/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 7:20 p.m.)
> 
> 
> Review request for Tellico.
> 
> 
> Bugs: 357799
>     http://bugs.kde.org/show_bug.cgi?id=357799
> 
> 
> Repository: tellico
> 
> 
> Description
> -------
> 
> Fix for bug #357799: [Internet Search] Result list is not cleared on new search
> 
> 
> Diffs
> -----
> 
>   src/configdialog.h a81d0bcbd3e6c5bd39b16478999f608e20ba79df 
>   src/configdialog.cpp 3f92d96d94db75f0f81f945a58df5987669da6c3 
>   src/core/tellico_config.kcfg a8ca3c4c860716477098c237e37985634a10db0e 
>   src/fetchdialog.cpp cf0a743806ba012a44fb8296a49cb12b29a4f0b7 
> 
> Diff: https://git.reviewboard.kde.org/r/126705/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven Werlen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/tellico-users/attachments/20160116/16eafe8a/attachment.html>


More information about the tellico-users mailing list