[Tellico-users] Contribution

[Sven Werlen]

Hi,

I found a way to better manage individual review requests separated by
using different local branches.
I recreated the review request for the additional 2 fields (boardgame).
I'm sorry for all the mails being generated on the mailing list because of
this.

> Thanks, Sven. At first glance, those looks great. I'm on travel right
now, but I'll get them pulled shortly.
Sure. No problem. Let me know if any of my contribution should be changed.

Btw... I love tellico. Thanks for creating it and maintaining it all these
years!

*Note: I also found the problem with tellicoui.rc and /usr/share/tellico
not beeing found.*
*I had to change the cmake install path to /usr (default is /usr/share).*

Sven



2016-01-08 6:13 GMT-05:00 Robby Stephenson <robby at periapsis.org>:

> On 01/06/2016 10:00 PM, Sven Werlen wrote:
>
>> Hi Robby,
>>
>> I filed 2 review board requests:
>> https://git.reviewboard.kde.org/r/126656/
>> https://git.reviewboard.kde.org/r/126657/<
>> https://git.reviewboard.kde.org/r/126656/>
>> /(in the second one, I only wanted to include the changes for the 2
>> additional fields but it automatically add the bug fix as well)/
>>
>
> Thanks, Sven. At first glance, those looks great. I'm on travel right now,
> but I'll get them pulled shortly.
>
>  > Are you developing againsht master or the 2.3 branch?
>> I used "master" branch for developping and testing. Should I rather use
>> the 2.3 branch?
>>
> The 2.3 branch is for KDE 4. I just wanted to be sure you were
> intentionally working with the KDE Frameworks 5 branch. I'll probably have
> one more 2.3.x release, I think, but that's it.
>
> In order to make Tellico work from my build folder, I had to apply 2
>> "hacks":
>>
>>  1. Add #define UIFILE QString::fromUtf8("PATH TO tellicoui.rc file") in
>>     src/mainwindow.h
>>  2. Create a symbolic link /usr/share/tellico to my tellico folder
>>
>> Without 1), Tellico was not able to find tellicoui.rc file and some menu
>> items were missing. I tried to change the "working dir" in KDevelop
>> without succes.
>> Without 2), Tellico was complaining about not finding Fancy.xsl at the
>> startup. I couldn't find any other way to make it work.
>>
>> Is there any other way to configure KDevelop and make it work?
>>
>
> I'll have to check. Not having Tellico installed otherwise, you mean?
>
> Last question: I think that "./src/fetch/scripts/boardgamegeek.rb" is
>> not used anymore. Can you confirm?
>>
>
> I think so, probably just need to remove it from that branch.
>
> Thanks!
> Robby
>



-- 
Sven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/tellico-users/attachments/20160110/40950ed4/attachment-0001.html>