[Tellico-users] Contribution

[Sven Werlen]

Hi Robby,

I filed 2 review board requests:
https://git.reviewboard.kde.org/r/126656/
https://git.reviewboard.kde.org/r/126657/
<https://git.reviewboard.kde.org/r/126656/>
*(in the second one, I only wanted to include the changes for the 2
additional fields but it automatically add the bug fix as well)*

> Are you developing against master or the 2.3 branch?
I used "master" branch for developping and testing. Should I rather use the
2.3 branch?

In order to make Tellico work from my build folder, I had to apply 2
"hacks":

   1. Add #define UIFILE QString::fromUtf8("PATH TO tellicoui.rc file") in
   src/mainwindow.h
   2. Create a symbolic link /usr/share/tellico to my tellico folder

Without 1), Tellico was not able to find tellicoui.rc file and some menu
items were missing. I tried to change the "working dir" in KDevelop without
succes.
Without 2), Tellico was complaining about not finding Fancy.xsl at the
startup. I couldn't find any other way to make it work.

Is there any other way to configure KDevelop and make it work?

Last question: I think that "./src/fetch/scripts/boardgamegeek.rb" is not
used anymore. Can you confirm?

Best regards,
Sven



2016-01-05 20:28 GMT-05:00 Robby Stephenson <robby at periapsis.org>:

> On 01/05/2016 08:10 PM, Sven Werlen wrote:
>
>> Hi,
>>
>> I've been working on some changes recently:
>>
>>   * [BoardGameGeek] New data fields : playing time & minimum age
>>   * Fix bug on collection field dialog with default button
>>
>> I'd like to contribute it back.
>>
>
> Great, thanks!
>
> What's the process for it?
>> Can I make a pull request on GitHub (https://github.com/KDE/tellico)?
>> There is another git repository on KDE (git://anongit.kde.org/tellico
>> <http://anongit.kde.org/tellico>/)./ Which one should I use?
>>
>
> I'm not sure what the github mirror is for. I think the easiest is if you
> can use the git://anongit.kde.org/tellico.git repo and file ReviewBoard
> requests.
> https://techbase.kde.org/Development/Review_Board
>
> Are you developing against master or the 2.3 branch?
>
> Robby
>



-- 
Sven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/tellico-users/attachments/20160106/5f242717/attachment-0001.html>