[Tellico-users] Review Request 120487: Switch to libdiscid for the CDROM track reading

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120487/
-----------------------------------------------------------

(Updated Oct. 9, 2014, 6:09 a.m.)


Status
------

This change has been marked as submitted.


Review request for Tellico.


Repository: tellico


Description
-------

Look for and use libdiscid for reading the CDROM tracks, removing all the OS-dependent code for that.


Diffs
-----

  CMakeLists.txt c4303e7e9274290ac32d8b75b650cf5e31ddc0ca 
  cmake/modules/FindDiscID.cmake PRE-CREATION 
  src/translators/CMakeLists.txt 807f22be68c66e455c8e6bcd246d77c958e47725 
  src/translators/freedb_util.cpp 58d34f2152f550532c41f1e74e0d84f23c993af9 
  config.h.cmake e55df834cc6210f4e8eb234fc2c53e87075cdd28 

Diff: https://git.reviewboard.kde.org/r/120487/diff/


Testing
-------

Builds fine with and without libdiscid.

I don't have audio CDs around, so I cannot properly test it works as well...


Thanks,

Pino Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/tellico-users/attachments/20141009/3ea8c8ac/attachment.html>