[Tellico-users] Review Request 119260: Missing target dependency for GUI

[Vadim Zhukov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119260/
-----------------------------------------------------------

(Updated Aug. 12, 2014, 12:55 a.m.)


Status
------

This change has been marked as submitted.


Review request for Build System and Tellico.


Repository: tellico


Description
-------

The "gui" target relies on data provided by "tellico-config" target. But there was no dependency chain between those, and this resulted in (sometimes) broken builds, especially involving Ninja backend for CMake. The patch below adds missing dependency and allows to compile Tellico on OpenBSD 100% time.

Please note that I do not have commit rights to the KDE repositories. That means, if the patch will be accepted, someone else will need to actually commit it. Thanks.


Diffs
-----

  src/gui/CMakeLists.txt e44db7b 

Diff: https://git.reviewboard.kde.org/r/119260/diff/


Testing
-------

OpenBSD/i386-CURRENT, KDE 4.13.3


Thanks,

Vadim Zhukov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/tellico-users/attachments/20140812/89276af5/attachment.html>