[Tellico-users] Review Request 119260: Missing target dependency for GUI

[Robby Stephenson]

I don't have a working computer with git access at the moment. Bug fixes
are still being done from the 2.3 branch, so this seems like an appropriate
fix for that branch.

Robby


On Sun, Aug 10, 2014 at 5:17 PM, Raphael Kubo da Costa <rakuco at freebsd.org>
wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119260/
>
> Hmm, the 2.3 branch still contains the problematic includes in src/gui/statusbar.cpp. Robby, how does branching work in Tellico? I can see that 2.3 is regularly merged into master, but the tags seem to be done to the 2.3 branch, and the tarball releases also seem to come from it, so packagers are still going to have problems.
>
>
> - Raphael Kubo da Costa
>
> On August 11th, 2014, 12:02 a.m. EEST, Vadim Zhukov wrote:
>   Review request for Build System and Tellico.
> By Vadim Zhukov.
>
> *Updated Aug. 11, 2014, 12:02 a.m.*
>  *Repository: * tellico
> Description
>
> The "gui" target relies on data provided by "tellico-config" target. But there was no dependency chain between those, and this resulted in (sometimes) broken builds, especially involving Ninja backend for CMake. The patch below adds missing dependency and allows to compile Tellico on OpenBSD 100% time.
>
> Please note that I do not have commit rights to the KDE repositories. That means, if the patch will be accepted, someone else will need to actually commit it. Thanks.
>
>   Testing
>
> OpenBSD/i386-CURRENT, KDE 4.13.3
>
>   Diffs
>
>    - src/gui/CMakeLists.txt (e44db7b)
>
> View Diff <https://git.reviewboard.kde.org/r/119260/diff/>
>
> _______________________________________________
> tellico-users mailing list
> tellico-users at kde.org
> https://mail.kde.org/mailman/listinfo/tellico-users
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/tellico-users/attachments/20140810/9cd58c01/attachment.html>