[Tellico-users] Review Request 117605: Fix wrong usage of QTextStream in csv parser

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117605/
-----------------------------------------------------------

(Updated April 17, 2014, 9:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for Tellico and Robby Stephenson.


Bugs: 329677
    http://bugs.kde.org/show_bug.cgi?id=329677


Repository: tellico


Description
-------

CSVParser::reset was wrongly passing the pointer of a parameter down to QTextStream so it should have crashed since once the function goes away the pointer is gone, but for some reason it did not crash and just infinite looped. Now we store the string locally together with the QTextStream.


Diffs
-----

  src/translators/csvparser.cpp ec30558 

Diff: https://git.reviewboard.kde.org/r/117605/diff/


Testing
-------

Opened the file from the bug, doesn't infinite loop anymore.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/tellico-users/attachments/20140417/79d3bcd8/attachment.html>