[Tellico-users] Review Request 101357: Add shortcut key to show/hide menubar (Bug 251157).

Albert Astals Cid aacid at kde.org
Sat Feb 9 13:05:28 UTC 2013


El Divendres, 8 de febrer de 2013, a les 16:15:57, Robby Stephenson va 
escriure:
> It's committed (the other Tellico one as well, 101358). When it says you
> changed the status to submitted, that means committed? Thanks for
> following up.

Well, reviewboard is not "very smart" so you have to tell it the reviews are 
commited so it does not appear anymore in the "pending" list.

There's three ways to make it marked as submitted (which is the commited name 
for reviewboard).
* One is using the 
    REVIEW: reviewnumber
  syntax in the commit message of the commit that commits a given reviewboard, 
  this will automatically close the reviewboard
* Another is the person that created the review using the "Close" 'combobox' 
that appears in the top header to mark it as submitted.
* An another is asking someone with enough reviewboard 'admin rights' to 
"Close" it for you (i.e. me)

Hope that helps making things a bit clearer.

Don't hesitate to ask!

Cheers,
  Albert

> 
> Robby
> 
> On 02/07/2013 01:24 PM, Albert Astals Cid wrote:
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/101357/
> > 
> > 
> > I see this has a ship it but marked as uncommited. Was it commited and you
> > forgot to close the request or is still uncommited?
> > 
> > 
> > - Albert
> > 
> > 
> > On May 13th, 2011, 5:43 p.m. UTC, Pedro MC wrote:
> > 
> > Review request for Tellico.
> > By Pedro MC.
> > 
> > /Updated May 13, 2011, 5:43 p.m./
> > 
> >   Description
> > 
> > Add shortcut key to show/hide menu bar. No menu entry is added.
> > One thing to be noted is that I changed the shortcut key for the internet
> > search to CTRL+I, from CTRL+M, to conform with the standard show/hide
> > menu shortcut key that is CTRL+M.> 
> >   Testing
> > 
> > Tested feature and it worked as expected.
> > 
> > *Bugs: * 251157 <http://bugs.kde.org/show_bug.cgi?id=251157>
> > 
> >   Diffs
> >   
> >   * ChangeLog (60c09c3)
> >   * src/mainwindow.h (88c1f16)
> >   * src/mainwindow.cpp (c425415)
> > 
> > View Diff <http://git.reviewboard.kde.org/r/101357/diff/>
> > 
> > 
> > 
> > _______________________________________________
> > tellico-users mailing list
> > tellico-users at kde.org
> > https://mail.kde.org/mailman/listinfo/tellico-users


More information about the tellico-users mailing list