patch for https://github.com/taglib/taglib/issues/850

Xiuyu Song XSong at roku.com
Fri Oct 18 16:49:01 BST 2019


Hi there:

I met a bug 850 when processing a wav file, which is PCM 24 bits width 5.1 channel.  Taglib 1.11 throws debug message of non pcm format and therefore does not return the length.  It seems that the wavproperties.cpp handles the format directly from wFormatTag field (offset 0), and does not consider that it is required to use the  WAVE_FORMAT_EXTENSIBLE for the PCM data with 16+ bits/sample, or 2+ channels, or actual number of bits/sample is not equal to container size or mapping from channels to speaker need to be specified.  The code should read the subFormat (offset 24).  I made a patch for this, but not know how to submit.  Attached in the email.  Please review.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/taglib-devel/attachments/20191018/78ccca12/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wavpcm_MIDLAND-3086.patch
Type: text/x-patch
Size: 1981 bytes
Desc: wavpcm_MIDLAND-3086.patch
URL: <http://mail.kde.org/pipermail/taglib-devel/attachments/20191018/78ccca12/attachment.bin>


More information about the taglib-devel mailing list