Missing virtual destructor in base classes

[Andy Champ]

Hi all,

we're using taglib in some of our code. I've noticed a warning going past that some of the taglib classes don't have a virtual destructor, but they're designed to be inherited from. This means of course that if a base class type pointer is deleted then cleanup on the derived type won't happen. I've seen a fix for some of these that doesn't fix it - it just disables the warning message if you're using GCC.


Does anyone know why a simple fix on the lines of


~classname() {}


wasn't added instead?


Thanks

Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/taglib-devel/attachments/20181204/593a3ae6/attachment.html>