Upgrading from 1.7 to 1.9 (wchar_t?)

[Tsuda Kageyu]

Hi Gayle, sorry for the inconvenience.

I have fixed the compilation errors occurs when "/Zc:wchar_t-" is set.
https://github.com/taglib/taglib/pull/297

I think that your attempt to keep the compiler options consistent is 
logical. Hope that the patch will be incorporated into the next release 
and your things goes well.

Kageyu.


>if I add "add_definitions ( /Zc:wchar_t-)" to CMakeLists.txt, the build
>fails:-
>
>[ 53%] Building CXX object taglib/CMakeFiles/tag.dir/toolkit/unicode.cpp.obj
>unicode.cpp
>c:\taglib\taglib-1.9\taglib\toolkit\unicode.h(118) : error C2146: syntax
>error : missing ';' before identifier 'UTF16'
>c:\taglib\taglib-1.9\taglib\toolkit\unicode.h(118) : error C4430: missing
>type specifier - int assumed. Note: C++ does not support default-int
>c:\taglib\taglib-1.9\taglib\toolkit\unicode.h(118) : error C4430: missing
>type specifier - int assumed. Note: C++ does not support default-int
>c:\taglib\taglib-1.9\taglib\toolkit\unicode.h(136) : error C2061: syntax
>error : identifier 'UTF16'
>c:\taglib\taglib-1.9\taglib\toolkit\unicode.h(139) : error C4430: missing
>type specifier - int assumed. Note: C++ does not support default-int
>c:\taglib\taglib-1.9\taglib\toolkit\unicode.h(139) : error C2143: syntax
>error : missing ',' before '*'
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(111) : error C4430: missing
>type specifier - int assumed. Note: C++ does not support default-int
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(111) : error C2143: syntax
>error : missing ',' before '*'
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(114) : error C4430: missing
>type specifier - int assumed. Note: C++ does not support default-int
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(114) : error C2143: syntax
>error : missing ';' before '*'
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(114) : error C2082:
>redefinition of formal parameter 'UTF16'
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(114) : error C2065: 'source'
>: undeclared identifier
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(114) : error C2065:
>'sourceStart' : undeclared identifier
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(115) : error C2065:
>'targetStart' : undeclared identifier
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(116) : error C2065: 'source'
>: undeclared identifier
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(116) : error C2065:
>'sourceEnd': undeclared identifier
>C:\taglib\taglib-1.9\taglib\toolkit\unicode.cpp(116) : fatal error C1903:
>unable to recover from previous error(s); stopping compilation
>
>Really not sure where to go from here......
>
>Gayle
>
>
>
>
>--
>View this message in context: http://kde.6490.n7.nabble.com/Upgrading-from-1-
>7-to-1-9-wchar-t-tp1545450p1545452.html
>Sent from the taglib-devel mailing list archive at Nabble.com.
>_______________________________________________
>taglib-devel mailing list
>taglib-devel at kde.org
>https://mail.kde.org/mailman/listinfo/taglib-devel