API compatibility

Tsuda Kageyu tsuda.kageyu at gmail.com
Sat Jun 1 17:56:26 UTC 2013


Hi fh.

The checks are equivalent in practice so it does not break the API.

Kageyu.

>Hi
>
>In commit "Reduce unnecessary memory copies by ByteVector", in function 
>"containsAt(...)" there was a change made to the sanity checking.
>
>Does this NOT break the API ?
>
>The code ... (messed by yahoo)
> // do some sanity checking -- all of these things are needed for the search 
>to be valid
>
>- if(patternLength > size() || offset >= size() || patternOffset >= pattern.
>size() || patternLength == 0)
>+ if(offset + patternLength > size() || patternOffset >= pattern.size() || 
>patternLength == 0)
>
>-Enjoy
>fh : )_~
>
>
>-------------------------------text/plain-------------------------------
>_______________________________________________
>taglib-devel mailing list
>taglib-devel at kde.org
>https://mail.kde.org/mailman/listinfo/taglib-devel
>
>-------------------------------text/plain-------------------------------
>_______________________________________________
>taglib-devel mailing list
>taglib-devel at kde.org
>https://mail.kde.org/mailman/listinfo/taglib-devel


More information about the taglib-devel mailing list