[PATCH] virtual *property* methods

Lukáš Lalinský lalinsky at gmail.com
Wed Feb 6 14:39:09 UTC 2013


Hi Sebastian,

Thank you for the patch, but I'm afraid this is duplicate work that has
already been done.

These methods are not virtual in the "master" branch for ABI compatibility
reasons. I think that all of them are already fixed in the "taglib2" branch:

https://github.com/taglib/taglib/tree/taglib2

Lukas


On Wed, Feb 6, 2013 at 3:32 PM, Sebastian Rachuj <rachus at web.de> wrote:

> Hello,
>
> I didn't see any further development in the last two weeks, so I thought
> that maybe I could help a bit. Since I didn't know where to start, I just
> made the *property* methods of "File" virtual and added the missing methods
> in other classes. Additionally I fixed a warning (virtual destructor for
> ‘TagLib::FileRef::FileTypeResolver’).
> I hope this patch could help with development.
>
> Best regards
> _______________________________________________
> taglib-devel mailing list
> taglib-devel at kde.org
> https://mail.kde.org/mailman/listinfo/taglib-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/taglib-devel/attachments/20130206/2bd44de5/attachment.html>


More information about the taglib-devel mailing list