Thread safety for ID3v1 genres

Stephen F. Booth me at sbooth.org
Mon May 2 22:05:10 CEST 2011


>> On Mon, May 2, 2011 at 1:27 PM, Stephen F. Booth <me at sbooth.org> wrote:
>>> I still would suggest the patch above, because no C++ objects are
>>> being created at static initialization time.
>>
>> I have no problem with the patch, the cost of creating the genre
>> string objects is nothing compared to the rest of the tag parsing.
>
> Thinking a bit more about it, I'd prefer something like this (because
> of ID3v1::genreIndex):

That should improve performance over the patch I suggested, although I
haven't benchmarked to be sure.

As an aside, does anyone even use ID3v1 tags anymore?  Isn't v1 from like 1996?

Stephen


More information about the taglib-devel mailing list