taglib fails to compile with MS VC++ 2010

Lukáš Lalinský lalinsky at gmail.com
Sat Jan 22 22:08:04 CET 2011


On Sat, Jan 22, 2011 at 7:49 PM, Tanguy Krotoff <tkrotoff at gmail.com> wrote:
> I don't get any warning when compiling mpegheader.cpp with this patch
> under Mac OS X SL (64 bits) with gcc 4.2.1 and -Wall -Wextra
> I don't remember to get a warning neither with MinGW under Windows XP (32 bits).
> Once compiled TagLib works fine as usual on both OS.
> I didn't try with an old version of Visual C++ (don't have one installed)

I specifically wanted somebody to test it on MS VC++ 2008 or older,
because I do not have such environment available. While it would be
nice to get rid of some warnings in a specific compiler, it doesn't
make much sense to me if it introduces warnings in some other
compiler. If that's the case, then I'd prefer to have some c++0x
#ifdef to work-around the warnings in both versions.

Anyway, I've committed the patch. If anybody can test with an old
MSVC, it would be great. Thanks.

Lukas


More information about the taglib-devel mailing list