ID3 Genre with number 0 (Blues)

Thomas Post post at equinux.com
Thu Mar 11 16:05:45 CET 2010


I think I discovered another bug:

id3v2framefactory.cpp line 430

String text = s.substr(end + 1);
int number = s.substr(1, end - 1).toInt();
if (number > 0 && number <= 255 && !(ID3v1::genre(number) == text))
	newfields.append(s.substr(1, end - 1));
if (!text.isEmpty())
	newfields.append(text);

Shouldn't that number > 0  be a >= 0? Because when I have a ID3v2 tag with a genre number (0), nothing is returned.

Thomas Post
-----------------------------------------------------------------------------------------------------------

equinux Aktiengesellschaft
Informationstechnologien
Kirschstraße 35
80999 München - Germany
Tel. +49-89-520465-339
Fax +49-89-520465-299
mailto:post at equinux.de
http://www.equinux.com/de
-----------------------------------------------------------------------------------------------------------
Vorstand: Till Schadde  -  Aufsichtsrat: Stefan Neuenhahn
USt-IdNr.: DE206360115  -  Sitz München  -  HRB München 129700
-----------------------------------------------------------------------------------------------------------

equinux USA, Inc.
100 Produce Ave. Suite L, South San Francisco, CA 94080 
Toll free: 1-888-equinux (1-888-3784689)
http://www.equinux.com
-----------------------------------------------------------------------------------------------------------

Stay updated what's going on at equinux
equinux Blog | equinux @ Twitter | equinux @ Facebook

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/taglib-devel/attachments/20100311/06adedff/attachment.htm 


More information about the taglib-devel mailing list