[Patch] Efficient ByteVector::replace() implementation

Lukáš Lalinský lalinsky at gmail.com
Thu Sep 17 09:36:21 CEST 2009

2009/9/17 Wladimir Palant <palant at songbirdnest.com>:
> On 17.09.2009 09:21, Lukáš Lalinský wrote:
>> Any chance I could convince you to write unit tests for the new code
>> paths in ByteVector::replace()?
> The chances are slim. I didn't manage to compile TagLib via the "official"
> build system and Songbird's makefile doesn't build unit tests. If you want
> to accept some untested unit tests - sure.

No, untested tests are not useful. :) The thing is, while I maintain
TagLib, I'll not commit any non-trivial patches without tests to make
sure we are not breaking things in the future. This is not really
about slowing anybody down, it's about code quality. In this case,
I'll have to write the tests, so it will take a little longer.

I've filled https://bugs.kde.org/show_bug.cgi?id=207664 to not forget
about it. Thank you for writing and sending the patch!

Lukas Lalinsky
lalinsky at gmail.com

More information about the taglib-devel mailing list