Don't ignore unsynchronisation flags in ID3v2 tag and frame headers

Scott Wheeler wheeler at kde.org
Tue Nov 6 18:52:05 CET 2007


Lukáš Lalinský wrote:
> On Ut, 2007-11-06 at 14:55 +0100, Scott Wheeler wrote:
>   
>> Specifically it's a binary / source incompatible API change, which
>> shouldn't go in as it is.  The only problem that I see at the moment is
>> to the createFrame method.  The old version needs to be supported, even
>> if it is marked as deprecated.  TagLib is still binary compatible back
>> to TagLib 1.0.
>>
>> If you leave the old one in place though, I'm fine with this being
>> checked in.
>>     
>
> Hm, what do you mean? The old one still is there and is redirected to
> the new one.

Yes, I see it now -- when I looked at the diff I saw:

-      Frame *createFrame(const ByteVector &data, uint version = 4) const;
+      Frame *createFrame(const ByteVector &data, Header *tagHeader) const;


...and didn't notice the lines above. Please commit.

-Scott


More information about the taglib-devel mailing list