wide char patch

Scott Wheeler wheeler at kde.org
Fri Nov 24 13:28:38 CET 2006


Yoshiki Yazawa wrote:
> Dear authors of taglib,
>
> I am Yoshiki Yazawa, a developer of audacious media player.
>
> Taglib is the primary tag library of our software. Thank you for the
> great library.
>
> I have a proposal to change the behavior when taglib is asked to
> return meta data in latin1. Current implementation simply picks up
> lower byte of internal ucs2be character and composes result string.
> However, this behavior easily ruins wide characters into unrecoverable
> garbage.
>
> I think it is very reasonable and safe if taglib checks wide character
> and returns an utf-8 string instead of a chain of lower bytes when the
> internal string has wide characters even though it was asked to return
> latin1.
>   
Hi Yoshiki --

Why not just request UTF-8 data?  I don't think it's acceptable to 
introduce indeterminism like this directly at the TagLib::String level.  
Maybe if I understood the problem that you're trying to solve we could 
solve it at a higher level...

-Scott


More information about the taglib-devel mailing list