itunes mp4 files

[Jochen Issing]

Hi Martin,

thanks for your corrections, I applied the patch and currently I am working on 
audio properties support. Tag writing will be next. Although this will take 
some time, because it is nontrivial for simple mp4file parsers.

Best Regards,

jochen

On Sunday 15 January 2006 17:45, Martin Aumueller wrote:
> Hi Jochen & others,
>
> thank you for making the code available and for doing the work - seems
> to have been quite a lot of it...
>
> I just tried your code out and as far as I can see it works fine for
> tag reading. I just noticed one problem: non-ascii characters get
> garbled because those are stored as UTF8 in the m4a file, but
> constructing a TagLib::String assumes a different encoding. This can
> be easily fixed by supplying String::UTF8 as additional parameter to
> the constructor - see the attached diff in file m4a/mp4file.cpp.
>
> As I am about to submit this to the amaroK svn repository for (in the
> end) replacing the libmp4v2 based m4a metadata code, I had to make
> some additional changes: there were some namespace problems when
> compiled standalone, so I had to change all those itunes*box.h files
> and boxfactory.cpp to explicitly use File from the correct namespace.
>
> Keep up the good work - I'm looking forward to tag writing support :)
>
> BTW, I made an error when generating this diff, so you would have to
> use patch -R to apply it.
>
> Martin
>
> On 1/14/06, Jochen Issing <jochen at isign-softart.de> wrote:
> > Here is the link:
> >
> > http://isign-softart.de/taglib/taglib-1.4_delivery_1_0.tar.bz2
> >
> > I modified the testing routine to use an MP4::Tag, so that I can test all
> > supported fields, not only the common ones. Therefore you should get a
> > bit more output...
> >
> > Best Regards,
> >
> > jochen
> >
> > On Saturday 14 January 2006 00:01, Michael Pyne wrote:
> > > On Monday 09 January 2006 17:21, Jochen Issing wrote:
> > > > > The features are for now read only of almost all supported mp4
> > > > > itunes fields, cover is left out for now, but could be included as
> > > > > well. No AudioProperties support yet, but will be my upcoming work.
> > > > > Write support will be last step for implementation, because this
> > > > > will be the most difficult part for me, especially rearding the
> > > > > offset tables, which I do not need to touch now.
> > >
> > > Hey, this is pretty awesome. :)  (Sorry for the late reply, btw)
> > >
> > > > > Besides that the code is not completely cleaned up (some #if
> > > > > 0-statements), because I might need those in future work. I tried
> > > > > to do as much Doxygen comments as I was able to do - the License
> > > > > Header is missing in some files as well.
> > >
> > > May I ask how you're doing this work?  There is existing code out there
> > > to merge MPEG-4 into TagLib but it is derived from mplayer (or libfaad,
> > > I forget which) and is thus license incompatible.
> > >
> > > If your work were to make its way to TagLib it would have to carry the
> > > same (or less restrictive) license.
> > >
> > > But if you managed to write the code by reverse-engineering the format
> > > or using documentation (i.e. not just reimplementing from other code),
> > > that would probably be OK.
> > >
> > > > > Please give me your opinion on the code, if the coding rules are
> > > > > matched good enough, if the structure is Ok or whatever. At least,
> > > > > give it a try! ;-)
> > >
> > > Um, where *is* the code?

-- 
 jochen issing
 gpg-sig: 0A121BC8
 www.isign-softart.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/taglib-devel/attachments/20060115/6ca33753/attachment.pgp