[education/rkward] rkward/settings: Revert "Do not force use of binary packages on Windows and Mac"
Thomas Friedrichsmeier
null at kde.org
Tue Sep 23 22:08:58 BST 2025
Git commit 4905261d9bd1a084de8398096ed5d29c3b2ca710 by Thomas Friedrichsmeier.
Committed on 23/09/2025 at 21:07.
Pushed by tfry into branch 'master'.
Revert "Do not force use of binary packages on Windows and Mac"
This reverts commit 5bc3111e16a1f4272b6ae51eafffb89b5ec3621b.
pkgType=both breaks .rk.get.package.installation.state() in its current
implementation. That will need a closer look.
M +1 -1 rkward/settings/rksettingsmoduler.cpp
https://invent.kde.org/education/rkward/-/commit/4905261d9bd1a084de8398096ed5d29c3b2ca710
diff --git a/rkward/settings/rksettingsmoduler.cpp b/rkward/settings/rksettingsmoduler.cpp
index 3cbf7f915..dd04d4ff5 100644
--- a/rkward/settings/rksettingsmoduler.cpp
+++ b/rkward/settings/rksettingsmoduler.cpp
@@ -519,7 +519,7 @@ QString RKSettingsModuleRPackages::pkgTypeOption() {
#if defined Q_OS_WIN || defined Q_OS_MACOS
ret.append(u"options (pkgType=\""_s);
if (source_packages) ret.append(u"source"_s);
- else ret.append(u"both"_s); // "automatically select appropriate binary, if available, else consider source package"
+ else ret.append(u"binary"_s); // "automatically select appropriate binary"
ret.append(u"\")\n"_s);
#endif
return ret;
More information about the rkward-tracker
mailing list