[education/rkward] rkward: Remove explicit warnings

[Thomas Friedrichsmeier]

Git commit 3d491005877b9e7c0c8bc0c7b1dec08b6e94123f by Thomas Friedrichsmeier.
Committed on 21/09/2025 at 19:36.
Pushed by tfry into branch 'master'.

Remove explicit warnings

M  +1    -3    rkward/core/rcontainerobject.cpp
M  +1    -3    rkward/core/robject.cpp
M  +1    -3    rkward/dataeditor/rkeditordataframe.cpp
M  +1    -3    rkward/plugin/rkcomponentproperties.cpp
M  +1    -3    rkward/plugin/rktabpage.cpp
M  +1    -3    rkward/rbackend/rkstructuregetter.cpp
M  +1    -3    rkward/rbackend/rkwarddevice/rkgraphicsdevice_frontendtransmitter.cpp
M  +2    -3    rkward/windows/rkcommandeditorwindow.cpp

https://invent.kde.org/education/rkward/-/commit/3d491005877b9e7c0c8bc0c7b1dec08b6e94123f

diff --git a/rkward/core/rcontainerobject.cpp b/rkward/core/rcontainerobject.cpp
index 0dca24f18..4d9b82d5f 100644
--- a/rkward/core/rcontainerobject.cpp
+++ b/rkward/core/rcontainerobject.cpp
@@ -283,9 +283,7 @@ RObject *RContainerObject::createPendingChild(const QString &name, int position,
 	RK_TRACE(OBJECTS);
 	RK_ASSERT(isType(GlobalEnv) || isInGlobalEnv());
 
-#ifdef __GNUC__
-#	warning TODO validize name
-#endif
+	// TODO: validize name? or is this always called with valid name?
 	RObject *ret;
 	if (container) {
 		ret = new RContainerObject(this, name);
diff --git a/rkward/core/robject.cpp b/rkward/core/robject.cpp
index 4e76004ce..287081993 100644
--- a/rkward/core/robject.cpp
+++ b/rkward/core/robject.cpp
@@ -514,9 +514,7 @@ bool RObject::updateDimensions(RData *new_data) {
 				return (true);
 			}
 		} else {
-#ifdef __GNUC__
-#	warning TODO: ugly hack. Should be moved to RKVariable, somehow.
-#endif
+			// TODO / HACK: Should be move to RKVariable, instead
 			if (type & Variable) static_cast<RKVariable *>(this)->extendToLength(new_dimensions[0]);
 
 			dimensions = new_dimensions;
diff --git a/rkward/dataeditor/rkeditordataframe.cpp b/rkward/dataeditor/rkeditordataframe.cpp
index cce81d0f4..4b664786b 100644
--- a/rkward/dataeditor/rkeditordataframe.cpp
+++ b/rkward/dataeditor/rkeditordataframe.cpp
@@ -104,11 +104,9 @@ void RKEditorDataFrame::waitForLoad() {
 	    open_chain);
 }
 
+// TODO: remove here, use model API, directly
 void RKEditorDataFrame::restoreObject(RObject *object) {
 	RK_TRACE(EDITOR);
 
-#ifdef __GNUC__
-#	warning TODO: this interface should be moved to the model for good.
-#endif
 	datamodel->restoreObject(object, nullptr);
 }
diff --git a/rkward/plugin/rkcomponentproperties.cpp b/rkward/plugin/rkcomponentproperties.cpp
index 9b43013bd..e1e8202b1 100644
--- a/rkward/plugin/rkcomponentproperties.cpp
+++ b/rkward/plugin/rkcomponentproperties.cpp
@@ -132,9 +132,7 @@ void RKComponentPropertyBase::connectToGovernor(RKComponentPropertyBase *governo
 
 void RKComponentPropertyBase::governorValueChanged(RKComponentPropertyBase *property) {
 	RK_TRACE(PLUGIN);
-#ifdef __GNUC__
-#	warning TOOD: connected value should be stored as qvariant
-#endif
+	// TODO:  connected value should be stored as qvariant
 	setValue(property->value(governor_modifier).toString());
 }
 
diff --git a/rkward/plugin/rktabpage.cpp b/rkward/plugin/rktabpage.cpp
index 66a2ed7d5..d500b1903 100644
--- a/rkward/plugin/rktabpage.cpp
+++ b/rkward/plugin/rktabpage.cpp
@@ -42,9 +42,7 @@ void RKTabPage::visibleEnabledChanged(RKComponentPropertyBase *property) {
 	if (property == visibility_property) {
 		if (visibility_property->boolValue()) {
 			if (!inserted) {
-#ifdef __GNUC__
-#	warning this may not be reliable, if an earlier page is invisible as well
-#endif
+				// TODO / WARNING: this may not be reliable, if an earlier page is invisible as well
 				tabbook->insertTab(index, this, label);
 				inserted = true;
 			}
diff --git a/rkward/rbackend/rkstructuregetter.cpp b/rkward/rbackend/rkstructuregetter.cpp
index 531dafddb..c4ee07329 100644
--- a/rkward/rbackend/rkstructuregetter.cpp
+++ b/rkward/rbackend/rkstructuregetter.cpp
@@ -223,9 +223,7 @@ void RKStructureGetter::getStructureWorker(SEXP val, const QString &name, int ad
 
 	// basic classification
 	for (int i = classes.size() - 1; i >= 0; --i) {
-#ifdef __GNUC__
-#	warning : Using is.data.frame() may be more reliable (would need to be called only on List-objects, thus no major performance hit)
-#endif
+		// TODO: Using is.data.frame() may be more reliable (would need to be called only on List-objects, thus no major performance hit)
 		if (classes[i] == QLatin1String("data.frame")) type |= RObject::DataFrame;
 	}
 
diff --git a/rkward/rbackend/rkwarddevice/rkgraphicsdevice_frontendtransmitter.cpp b/rkward/rbackend/rkwarddevice/rkgraphicsdevice_frontendtransmitter.cpp
index 75c087734..b3e0d1e6a 100644
--- a/rkward/rbackend/rkwarddevice/rkgraphicsdevice_frontendtransmitter.cpp
+++ b/rkward/rbackend/rkwarddevice/rkgraphicsdevice_frontendtransmitter.cpp
@@ -195,9 +195,7 @@ static QFont readFont(QDataStream &instream) {
 	quint8 fontface;
 	QString fontfamily;
 	instream >> cex >> ps >> lineheight >> fontface >> fontfamily;
-#ifdef __GNUC__
-#	warning TODO deal with line-height
-#endif
+	// TODO: deal with lineheight!
 	QFont ret;
 	if (!(fontfamily.isEmpty() || fontfamily == QLatin1String("Symbol"))) ret.setFamily(fontfamily); // NOTE: QPainter won't paint with "Symbol", somehow
 	if (fontface == 2 || fontface == 4) ret.setWeight(QFont::Bold);
diff --git a/rkward/windows/rkcommandeditorwindow.cpp b/rkward/windows/rkcommandeditorwindow.cpp
index 2fb9ad71e..233d0fdc3 100644
--- a/rkward/windows/rkcommandeditorwindow.cpp
+++ b/rkward/windows/rkcommandeditorwindow.cpp
@@ -252,9 +252,8 @@ RKCommandEditorWindow::RKCommandEditorWindow(QWidget *parent, const QUrl &_url,
 
 	connect(m_doc, &KTextEditor::Document::documentUrlChanged, this, &RKCommandEditorWindow::urlChanged);
 	connect(m_doc, &KTextEditor::Document::modifiedChanged, this, &RKCommandEditorWindow::updateCaption); // of course most of the time this causes a redundant call to updateCaption. Not if a modification is undone, however.
-#ifdef __GNUC__
-#	warning remove this in favor of KTextEditor::Document::restore()
-#endif
+
+	// TODO: remove custom autosave mechanism in favor of KTextEditor::Document::restore()
 	connect(m_doc, &KTextEditor::Document::modifiedChanged, this, &RKCommandEditorWindow::autoSaveHandlerModifiedChanged);
 	connect(m_doc, &KTextEditor::Document::textChanged, this, &RKCommandEditorWindow::textChanged);
 	connect(m_view, &KTextEditor::View::selectionChanged, this, &RKCommandEditorWindow::selectionChanged);