[education/rkward] rkward/windows: Cleanup

[Thomas Friedrichsmeier]

Git commit e52b78dc315fb28877aa14d519ccc17b32a77306 by Thomas Friedrichsmeier.
Committed on 20/09/2025 at 11:10.
Pushed by tfry into branch 'master'.

Cleanup

M  +2    -3    rkward/windows/rkcodecompletion.cpp
M  +3    -3    rkward/windows/rkcodecompletion.h

https://invent.kde.org/education/rkward/-/commit/e52b78dc315fb28877aa14d519ccc17b32a77306

diff --git a/rkward/windows/rkcodecompletion.cpp b/rkward/windows/rkcodecompletion.cpp
index 63f164824..c14cf9490 100644
--- a/rkward/windows/rkcodecompletion.cpp
+++ b/rkward/windows/rkcodecompletion.cpp
@@ -9,7 +9,6 @@ SPDX-License-Identifier: GPL-2.0-or-later
 #include <KActionCollection>
 #include <KLocalizedString>
 #include <ktexteditor/document.h>
-#include <ktexteditor/documentcursor.h>
 #include <ktexteditor/editor.h>
 
 #include <QAction>
@@ -286,7 +285,7 @@ void RKCompletionManager::startModel(KTextEditor::CodeCompletionModel *model, bo
 	if (start && range.isValid() && !range.isEmpty()) {
 		if (!started_models.contains(model)) {
 			// TODO: should merge these calls for several models at once
-			_view->startCompletion(range, QList<KTextEditor::CodeCompletionModel *>({model}), user_triggered ? KTextEditor::CodeCompletionModel::ManualInvocation : KTextEditor::CodeCompletionModel::AutomaticInvocation);
+			_view->startCompletion(range, {model}, user_triggered ? KTextEditor::CodeCompletionModel::ManualInvocation : KTextEditor::CodeCompletionModel::AutomaticInvocation);
 			started_models.append(model);
 		}
 		auto ci = dynamic_cast<KTextEditor::CodeCompletionModelControllerInterface *>(model);
@@ -738,7 +737,7 @@ void RKCallHintModel::setFunction(RObject *_function) {
 	beginResetModel();
 	if (function && function->isType(RObject::Function)) {
 		// initialize hint
-		RFunctionObject *fo = static_cast<RFunctionObject *>(function);
+		const RFunctionObject *fo = static_cast<RFunctionObject *>(function);
 		name = fo->getFullName();
 		QStringList args = fo->argumentNames();
 		QStringList defs = fo->argumentDefaults();
diff --git a/rkward/windows/rkcodecompletion.h b/rkward/windows/rkcodecompletion.h
index 2645d44f1..2dafd1a3c 100644
--- a/rkward/windows/rkcodecompletion.h
+++ b/rkward/windows/rkcodecompletion.h
@@ -216,9 +216,9 @@ class RKDynamicCompletionsAddition : public QObject {
 	explicit RKDynamicCompletionsAddition(RKCompletionModelBase *parent);
 	~RKDynamicCompletionsAddition();
 	void update(const QString &mode, const QString &fragment, const QString &filterprefix, const QStringList &filterlist);
-	const QStringList results() const { return filtered_results; };
-	const QString fragment() const { return current_fragment; };
-	const QString mode() const { return current_mode; };
+	const QStringList &results() const { return filtered_results; };
+	const QString &fragment() const { return current_fragment; };
+	const QString &mode() const { return current_mode; };
   Q_SIGNALS:
 	void resultsComplete();