[education/rkward] rkward/windows: More consistent behavior when top/bottom is reached
Thomas Friedrichsmeier
null at kde.org
Mon May 26 15:06:38 BST 2025
Git commit c26575fcdb209589da2af46b4ebf2246fdd0af84 by Thomas Friedrichsmeier.
Committed on 26/05/2025 at 14:06.
Pushed by tfry into branch 'master'.
More consistent behavior when top/bottom is reached
M +9 -8 rkward/windows/rkcodenavigation.cpp
https://invent.kde.org/education/rkward/-/commit/c26575fcdb209589da2af46b4ebf2246fdd0af84
diff --git a/rkward/windows/rkcodenavigation.cpp b/rkward/windows/rkcodenavigation.cpp
index dd7df63db..dc2b9c0b4 100644
--- a/rkward/windows/rkcodenavigation.cpp
+++ b/rkward/windows/rkcodenavigation.cpp
@@ -128,6 +128,15 @@ class RKCodeNavigationInternal : public QObject {
void navigate(const StoredPosition &newpos) const {
RK_TRACE(APP);
+ if (!newpos.message.isEmpty()) {
+ auto msg = new KTextEditor::Message(newpos.message, KTextEditor::Message::Information);
+ msg->setPosition(KTextEditor::Message::BottomInView);
+ msg->setAutoHide(2000);
+ msg->setAutoHideMode(KTextEditor::Message::Immediate);
+ doc->postMessage(msg);
+ return;
+ }
+
RK_DEBUG(COMMANDEDITOR, DL_DEBUG, "navigate to %d", newpos.pos);
// translate final position back to cursor coordinates
if (!newpos.selection.isEmpty()) {
@@ -137,14 +146,6 @@ class RKCodeNavigationInternal : public QObject {
view->setCursorPosition(positionToCursor(newpos.pos));
view->setSelection(KTextEditor::Range(-1, -1, -1, -1));
}
-
- if (!newpos.message.isEmpty()) {
- auto msg = new KTextEditor::Message(newpos.message, KTextEditor::Message::Information);
- msg->setPosition(KTextEditor::Message::BottomInView);
- msg->setAutoHide(2000);
- msg->setAutoHideMode(KTextEditor::Message::Immediate);
- doc->postMessage(msg);
- }
}
int cursorToPosition(const KTextEditor::Cursor &cursor) const {
More information about the rkward-tracker
mailing list