[education/rkward] rkward/rbackend/rkwarddevice: Fix potential race condition

Thomas Friedrichsmeier null at kde.org
Sun Jun 30 11:15:28 BST 2024


Git commit f52c91774b24891b01bc58ebdf14b3c127f3545d by Thomas Friedrichsmeier.
Committed on 30/06/2024 at 10:15.
Pushed by tfry into branch 'master'.

Fix potential race condition

M  +1    -0    rkward/rbackend/rkwarddevice/rkgraphicsdevice.cpp

https://invent.kde.org/education/rkward/-/commit/f52c91774b24891b01bc58ebdf14b3c127f3545d

diff --git a/rkward/rbackend/rkwarddevice/rkgraphicsdevice.cpp b/rkward/rbackend/rkwarddevice/rkgraphicsdevice.cpp
index f77c8a005..a5725ee28 100644
--- a/rkward/rbackend/rkwarddevice/rkgraphicsdevice.cpp
+++ b/rkward/rbackend/rkwarddevice/rkgraphicsdevice.cpp
@@ -242,6 +242,7 @@ void RKGraphicsDevice::clear(const QBrush& brush) {
 }
 
 void RKGraphicsDevice::setAreaSize (const QSize& size) {
+	if (!view) return; // RK.resize() calls, being priority commands, may sometimes arrive after viewKilled()
 	if (painter.isActive ()) painter.end ();
 	RK_DEBUG (GRAPHICS_DEVICE, DL_INFO, "New Size %d, %d (view size is %d, %d)", size.width (), size.height (), view->width (), view->height ());
 #ifdef USE_QIMAGE_BUFFER


More information about the rkward-tracker mailing list