[education/rkward] /: Fix save to file option in basic statics plugin

[Thomas Friedrichsmeier]

Git commit b6d8a2361e3ec0303d8017d8f5d1dd4e433d294f by Thomas Friedrichsmeier.
Committed on 28/06/2024 at 14:04.
Pushed by tfry into branch 'master'.

Fix save to file option in basic statics plugin

M  +1    -0    ChangeLog
M  +3    -2    rkward/plugin/rkpluginbrowser.cpp
M  +2    -0    rkward/plugins/uni1.2/description.xml

https://invent.kde.org/education/rkward/-/commit/b6d8a2361e3ec0303d8017d8f5d1dd4e433d294f

diff --git a/ChangeLog b/ChangeLog
index f185abb9c..c4a84e51e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,4 @@
+- Fixed: Basic statistics would refuse to "overwrite file", even if saving to file was unchecked
 - Added: Ability to open PDF documents inside the RKWard window, and associated R function rk.show.pdf()
 - Fixed: Add breeze icons as a fallback on systems that use a different icon theme (fixes missing icons)
 - Added: Setup dialog includes setting to select a different R installation
diff --git a/rkward/plugin/rkpluginbrowser.cpp b/rkward/plugin/rkpluginbrowser.cpp
index 30814576b..07168fca2 100644
--- a/rkward/plugin/rkpluginbrowser.cpp
+++ b/rkward/plugin/rkpluginbrowser.cpp
@@ -1,6 +1,6 @@
 /*
 rkpluginbrowser - This file is part of RKWard (https://rkward.kde.org). Created: Sat Mar 10 2005
-SPDX-FileCopyrightText: 2018 by Thomas Friedrichsmeier <thomas.friedrichsmeier at kdemail.net>
+SPDX-FileCopyrightText: 2005-2024 by Thomas Friedrichsmeier <thomas.friedrichsmeier at kdemail.net>
 SPDX-FileContributor: The RKWard Team <rkward-devel at kde.org>
 SPDX-License-Identifier: GPL-2.0-or-later
 */
@@ -30,7 +30,8 @@ RKPluginBrowser::RKPluginBrowser (const QDomElement &element, RKComponent *paren
 	connect (selection, &RKComponentPropertyBase::valueChanged, this, &RKPluginBrowser::textChanged);
 
 	setRequired (xml->getBoolAttribute (element, "required", true, DL_INFO));
-	connect (requirednessProperty (), &RKComponentPropertyBase::valueChanged, this, &RKPluginBrowser::validateInput);
+	connect(requirednessProperty(), &RKComponentPropertyBase::valueChanged, this, &RKPluginBrowser::validateInput);
+	connect(enablednessProperty(), &RKComponentPropertyBase::valueChanged, this, &RKPluginBrowser::validateInput);
 
 	QVBoxLayout *vbox = new QVBoxLayout (this);
 	vbox->setContentsMargins (0, 0, 0, 0);
diff --git a/rkward/plugins/uni1.2/description.xml b/rkward/plugins/uni1.2/description.xml
index 4e277e5ff..287808250 100644
--- a/rkward/plugins/uni1.2/description.xml
+++ b/rkward/plugins/uni1.2/description.xml
@@ -8,6 +8,8 @@ SPDX-License-Identifier: GPL-2.0-or-later
 <document>
 	<code file="code.js"/>
 	<logic>
+		<connect client="file.enabled" governor="save_to_file.state" />
+
 		<connect client="constMad.enabled" governor="mad.state" />
 		<connect client="pourcent.enabled" governor="trim.state" />
 		<connect client="winsor.enabled" governor="huber.state" />