[education/rkward] rkward/rbackend: Clarifications

[Thomas Friedrichsmeier]

Git commit 7a34d66ccac4fe9965343e52ca1d2b9fe80ac55f by Thomas Friedrichsmeier.
Committed on 24/06/2024 at 20:41.
Pushed by tfry into branch 'master'.

Clarifications

M  +2    -2    rkward/rbackend/rkrbackend_dlopen.cpp

https://invent.kde.org/education/rkward/-/commit/7a34d66ccac4fe9965343e52ca1d2b9fe80ac55f

diff --git a/rkward/rbackend/rkrbackend_dlopen.cpp b/rkward/rbackend/rkrbackend_dlopen.cpp
index 075c9800c..d5681a7c0 100644
--- a/rkward/rbackend/rkrbackend_dlopen.cpp
+++ b/rkward/rbackend/rkrbackend_dlopen.cpp
@@ -41,12 +41,12 @@ auto loadlib(const char* name) {
 	auto ret = LoadLibraryA(name);
 #elif 0 && defined(LM_ID_NEWLM) && !defined(__SANITIZE_ADDRESS__)
 	// NOTE / TODO: with this, we get Cstack use too close to the limit when loading library(tcltk)
+	// This applies even when loading RK_BACKEND_LIB with dlmopen() and libR.so with plain dlopen(), or vice-versa
 	auto ret = dlmopen(LM_ID_NEWLM, name, RTLD_NOW | RTLD_LOCAL);
 #elif defined(RTLD_DEEPBIND) && !defined(__SANITIZE_ADDRESS__)
 	auto ret = dlopen(name, RTLD_NOW | RTLD_LOCAL | RTLD_DEEPBIND);
 #else
-	auto ret = dlopen(name, RTLD_NOW | RTLD_LOCAL);  // NOTE: RTLD_DEEPBIND causes undiagnosed runtime failure on Suse Tumbleweed around 05/24 (while it works, elsewhere)
-	                                                 //       possibly again due to address sanitization on the gitlab job?
+	auto ret = dlopen(name, RTLD_NOW | RTLD_LOCAL);  // NOTE: RTLD_DEEPBIND or dlmopen causs runtime failure with address sanitization
 #endif
 	if (!ret) {
 #ifdef Win32