[education/rkward] rkward/misc: Fix workspace browser name filter

Thomas Friedrichsmeier null at kde.org
Sat Jun 15 13:45:57 BST 2024


Git commit 04b3d7c75442b461c73649a63679cae3c6e6eaf3 by Thomas Friedrichsmeier.
Committed on 15/06/2024 at 12:45.
Pushed by tfry into branch 'master'.

Fix workspace browser name filter

M  +1    -1    rkward/misc/rkobjectlistview.cpp

https://invent.kde.org/education/rkward/-/commit/04b3d7c75442b461c73649a63679cae3c6e6eaf3

diff --git a/rkward/misc/rkobjectlistview.cpp b/rkward/misc/rkobjectlistview.cpp
index 35f36e0ea..d68962019 100644
--- a/rkward/misc/rkobjectlistview.cpp
+++ b/rkward/misc/rkobjectlistview.cpp
@@ -432,7 +432,7 @@ bool RKObjectListViewSettings::acceptRow (int source_row, const QModelIndex& sou
 	if (hide_functions && object->isType (RObject::Function)) return false;
 	if (hide_non_functions && !object->isType (RObject::Function)) return false;
 
-	if (filterRegularExpression ().isValid ()) return true;
+	if (filterRegularExpression().pattern().isEmpty()) return true;
 	if (filter_on_name && object->getShortName ().contains (filterRegularExpression ())) return true;
 	if (filter_on_label && object->getLabel ().contains (filterRegularExpression ())) return true;
 	if (filter_on_class) {


More information about the rkward-tracker mailing list