[education/rkward] rkward/windows: Remove obsolete workaround
Thomas Friedrichsmeier
null at kde.org
Tue Jun 11 22:01:17 BST 2024
Git commit fc27547ff5d9159a445664dbfc6219f246a2908e by Thomas Friedrichsmeier.
Committed on 11/06/2024 at 14:19.
Pushed by tfry into branch 'master'.
Remove obsolete workaround
M +1 -17 rkward/windows/rkcodecompletion.cpp
https://invent.kde.org/education/rkward/-/commit/fc27547ff5d9159a445664dbfc6219f246a2908e
diff --git a/rkward/windows/rkcodecompletion.cpp b/rkward/windows/rkcodecompletion.cpp
index 71cce3b78..dca5110f9 100644
--- a/rkward/windows/rkcodecompletion.cpp
+++ b/rkward/windows/rkcodecompletion.cpp
@@ -52,22 +52,6 @@ public:
//////////////////////// RKCompletionManager //////////////////////
#include <KAboutData>
#include <KMessageBox>
-bool checkSaneVersion() {
- static enum { Unknown, Ok, Bad } version_check = Unknown;
- if (version_check == Unknown) {
- KAboutData d = KTextEditor::Editor::instance()->aboutData();
- if (d.version() == "5.92.0") {
- KMessageBox::information(nullptr, i18n("Due to a bug in version 5.92.0 of ktexteditor (the version in use, right now), the function call tip feature would"
- " crash, and has been disabled in this session. To enable the call tip, install any other (earlier or later) version of (lib|kf5)ktexteditor."),
- i18n("Incompatible version of ktexteditor"), "ktexteditor_v5.92.0");
- version_check = Bad;
- } else {
- version_check = Ok;
- }
- }
- return version_check == Ok;
-}
-
RKCompletionManager::RKCompletionManager(KTextEditor::View* view, const RKCodeCompletionSettings *settings) : QObject(view), settings(settings) {
RK_TRACE (COMMANDEDITOR);
@@ -310,7 +294,7 @@ void RKCompletionManager::updateVisibility () {
startModel(kate_keyword_completion_model, min_len, symbol_range);
}
// NOTE: Freaky bug in KF 5.44.0: Call hint will not show for the first time, if logically above the primary screen. TODO: provide patch for kateargumenthinttree.cpp:166pp
- startModel(callhint_model, checkSaneVersion() && settings->isEnabled(RKCodeCompletionSettings::Calltip), currentCallRange());
+ startModel(callhint_model, settings->isEnabled(RKCodeCompletionSettings::Calltip), currentCallRange());
startModel(arghint_model, settings->isEnabled(RKCodeCompletionSettings::Arghint), argname_range);
}
More information about the rkward-tracker
mailing list