[education/rkward] rkward/dialogs: Fix config storage for R inside AppImage

Thomas Friedrichsmeier null at kde.org
Sun Jun 9 21:47:03 BST 2024


Git commit 9138ecd798e3a58e303a7434102aa2eeba9f5a7f by Thomas Friedrichsmeier.
Committed on 09/06/2024 at 20:46.
Pushed by tfry into branch 'master'.

Fix config storage for R inside AppImage

M  +7    -1    rkward/dialogs/rksetupwizard.cpp

https://invent.kde.org/education/rkward/-/commit/9138ecd798e3a58e303a7434102aa2eeba9f5a7f

diff --git a/rkward/dialogs/rksetupwizard.cpp b/rkward/dialogs/rksetupwizard.cpp
index 3780468c6..17c443ce9 100644
--- a/rkward/dialogs/rksetupwizard.cpp
+++ b/rkward/dialogs/rksetupwizard.cpp
@@ -550,8 +550,14 @@ void RKSetupWizard::fullInteractiveCheck(InvokationReason reason, const QList<RK
 			RInterface::issueCommand(wizard->r_commands_to_run[i], RCommand::App);
 		}
 
+		// save backend selection (if one was made)
 		if (!RInterface::instance()->backendIsDead() && (RKSessionVars::RBinary() != old_r_binary)) {
-			RKSettingsModuleR::options_r_binary = RKSessionVars::RBinary();
+			if (RKSessionVars::isPathInAppImage(RKSessionVars::RBinary())) {
+				// the appimage path isn't stable, but leaving this empty causes it to be used by default (via rkward.ini)
+				RKSettingsModuleR::options_r_binary = QString();;
+			} else {
+				RKSettingsModuleR::options_r_binary = RKSessionVars::RBinary();
+			}
 		}
 	}
 


More information about the rkward-tracker mailing list