[education/rkward] rkward/rbackend: Some comments

Thomas Friedrichsmeier null at kde.org
Thu Apr 18 17:40:15 BST 2024


Git commit 4aae824303fafe0dbc758a71920bb90b0c59991b by Thomas Friedrichsmeier.
Committed on 18/04/2024 at 16:38.
Pushed by tfry into branch 'master'.

Some comments

M  +3    -3    rkward/rbackend/rkrinterface.cpp

https://invent.kde.org/education/rkward/-/commit/4aae824303fafe0dbc758a71920bb90b0c59991b

diff --git a/rkward/rbackend/rkrinterface.cpp b/rkward/rbackend/rkrinterface.cpp
index 28e2b61ec..876d04ffe 100644
--- a/rkward/rbackend/rkrinterface.cpp
+++ b/rkward/rbackend/rkrinterface.cpp
@@ -81,7 +81,9 @@ RInterface::RInterface () {
 	backend_dead = false;
 	dummy_command_on_stack = nullptr;
 
-	// create a fake init command
+	// Create a fake init command. This is the top level command designed to capture all output of the startup sequence.
+	// The backend will fetch this command, then send a BackendRequest::Started event. In response to this, we will send further
+	// (sub)-commands to set everything up (see there).
 	auto fake_c = new RCommand(i18n("R Startup"), RCommand::App | RCommand::Sync | RCommand::ObjectListUpdate, i18n("R Startup"));
 	fake_c->whenFinished(this, [this](RCommand *command) {
 		QString message = startup_errors;
@@ -437,8 +439,6 @@ void RInterface::handleRequest (RBackendRequest* request) {
 			RK_ASSERT (command->getDataLength () == 1);
 			RKSettingsModuleR::help_base_url = command->stringVector ().value (0);
 		});
-
-		// NOTE: more initialization commands get run *after* we have determined the standard library locations (see rCommandDone())
 	} else {
 		processRBackendRequest (request);
 	}



More information about the rkward-tracker mailing list