[education/rkward/kf5] /: Enable cppcheck

Thomas Friedrichsmeier null at kde.org
Wed Apr 10 16:12:08 BST 2024


Git commit 51920c9802e883cc23134276e88073b870d83e11 by Thomas Friedrichsmeier.
Committed on 07/04/2024 at 21:17.
Pushed by tfry into branch 'kf5'.

Enable cppcheck

M  +2    -1    .gitlab-ci.yml
M  +1    -1    rkward/windows/rkwindowcatcher.cpp

https://invent.kde.org/education/rkward/-/commit/51920c9802e883cc23134276e88073b870d83e11

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 088d5104d..f0692942f 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -5,6 +5,7 @@ include:
   - project: sysadmin/ci-utilities
     file:
       - /gitlab-templates/reuse-lint.yml
+      - /gitlab-templates/cppcheck.yml
       - /gitlab-templates/linux-qt6.yml
       - /gitlab-templates/freebsd-qt6.yml
       - /gitlab-templates/windows-qt6.yml
@@ -12,4 +13,4 @@ include:
       - /gitlab-templates/craft-appimage-qt6.yml
       - /gitlab-templates/craft-macos-x86-64-qt6.yml
       - /gitlab-templates/craft-macos-arm64-qt6.yml
-      - /gitlab-templates/craft-windows-x86-64-qt6.yml
\ No newline at end of file
+      - /gitlab-templates/craft-windows-x86-64-qt6.yml
diff --git a/rkward/windows/rkwindowcatcher.cpp b/rkward/windows/rkwindowcatcher.cpp
index cfc0b2817..585faccfa 100644
--- a/rkward/windows/rkwindowcatcher.cpp
+++ b/rkward/windows/rkwindowcatcher.cpp
@@ -129,7 +129,7 @@ void RKWindowCatcher::stop (int new_cur_device) {
 #endif
 		} else {
 #if defined Q_OS_MACOS
-			KMessageBox::information (0, i18n ("You have tried to embed a new R graphics device window in RKWard. However, this is not currently supported in this build of RKWard on Mac OS X. See https://rkward.kde.org/mac for more information."), i18n ("Could not embed R X11 window"), "embed_x11_device_not_supported");
+			KMessageBox::information(nullptr, i18n("You have tried to embed a new R graphics device window in RKWard. However, this is not currently supported in this build of RKWard on Mac OS X. See https://rkward.kde.org/mac for more information."), i18n("Could not embed R X11 window"), "embed_x11_device_not_supported");
 #else
 			RKErrorDialog::reportableErrorMessage (nullptr, i18n ("You have tried to embed a new R graphics device window in RKWard. However, either no window was created, or RKWard failed to detect the new window. If you think RKWard should have done better, consider reporting this as a bug. Alternatively, you may want to adjust Settings->Configure RKWard->Onscreen Graphics."), QString (), i18n ("Could not embed R X11 window"), "failure_to_detect_x11_device");
 #endif



More information about the rkward-tracker mailing list