[education/rkward] rkward/misc: Remove obsolete signal and slot

Thomas Friedrichsmeier null at kde.org
Sun Jul 16 15:16:50 BST 2023


Git commit 2156292d69b597cf99403c05a352f3a4b7eb6654 by Thomas Friedrichsmeier.
Committed on 16/07/2023 at 13:51.
Pushed by tfry into branch 'master'.

Remove obsolete signal and slot

M  +0    -7    rkward/misc/rkobjectlistview.cpp
M  +0    -2    rkward/misc/rkobjectlistview.h

https://invent.kde.org/education/rkward/-/commit/2156292d69b597cf99403c05a352f3a4b7eb6654

diff --git a/rkward/misc/rkobjectlistview.cpp b/rkward/misc/rkobjectlistview.cpp
index 1d623abca..7e9b46c95 100644
--- a/rkward/misc/rkobjectlistview.cpp
+++ b/rkward/misc/rkobjectlistview.cpp
@@ -126,12 +126,6 @@ RObject* RKObjectListView::objectAtIndex (const QModelIndex& index) const {
 	return static_cast<RObject*> (settings->mapToSource (index).internalPointer ());
 }
 
-void RKObjectListView::selectionChanged (const QItemSelection&, const QItemSelection&) {
-	RK_TRACE (APP);
-
-	emit selectionChanged();
-}
-
 RObject::ObjectList RKObjectListView::selectedObjects () const {
 	RK_TRACE (APP);
 
@@ -171,7 +165,6 @@ void RKObjectListView::initialize () {
 
 	connect (RObjectList::getObjectList (), &RObjectList::updateComplete, this, &RKObjectListView::updateComplete);
 	connect (RObjectList::getObjectList (), &RObjectList::updateStarted, this, &RKObjectListView::updateStarted);
-	connect (selectionModel (), &QItemSelectionModel::selectionChanged, this, static_cast<void (RKObjectListView::*)(const QItemSelection&, const QItemSelection&)>(&RKObjectListView::selectionChanged));
 	connect (settings, &RKObjectListViewSettings::settingsChanged, this, &RKObjectListView::settingsChanged);
 
 	updateComplete ();
diff --git a/rkward/misc/rkobjectlistview.h b/rkward/misc/rkobjectlistview.h
index 2e1a0bbf1..822b85a7b 100644
--- a/rkward/misc/rkobjectlistview.h
+++ b/rkward/misc/rkobjectlistview.h
@@ -53,14 +53,12 @@ from your custom menu items, to figure out, which object you should operate on.
 /** Takes care initializing the RKObjectListView */
 	void initialize ();
 signals:
-	void selectionChanged ();
 /** This signal is emitted just before the context-menu is shown. If you connect to this signal, you can make some adjustments to the context-menu.
 If you set *suppress to true, showing the context menu will be suppressed. */
 	void aboutToShowContextMenu (RObject *object, bool *suppress);
 public slots:
 	void updateComplete ();
 	void updateStarted ();
-	void selectionChanged (const QItemSelection & selected, const QItemSelection & deselected) override;
 	void settingsChanged ();
 	void itemClicked (const QModelIndex& index);
 protected:



More information about the rkward-tracker mailing list