[education/rkward] rkward: Missing semicolon

Thomas Friedrichsmeier null at kde.org
Thu Mar 31 14:35:11 BST 2022


Git commit c29768ce1b9c9193dec190a8495bcf036b768490 by Thomas Friedrichsmeier.
Committed on 31/03/2022 at 13:35.
Pushed by tfry into branch 'master'.

Missing semicolon

M  +1    -1    rkward/CMakeLists.txt
M  +1    -1    rkward/windows/rktoplevelwindowgui.cpp

https://invent.kde.org/education/rkward/commit/c29768ce1b9c9193dec190a8495bcf036b768490

diff --git a/rkward/CMakeLists.txt b/rkward/CMakeLists.txt
index f15ffaeb..109b2a44 100644
--- a/rkward/CMakeLists.txt
+++ b/rkward/CMakeLists.txt
@@ -44,7 +44,7 @@ GET_DIRECTORY_PROPERTY(R_SHAREDLIBDIR DIRECTORY rbackend LINK_DIRECTORIES)
 LINK_DIRECTORIES(${R_SHAREDLIBDIR})
 
 FILE(GLOB ICON_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/icons/app-icon/*-apps-rkward.png")
-# recent ECM versions will prefer the scalable version: prepend it to the icon source list:
+# recent ECM versions will prefer the scalable version: prepend it to the icon source list (older versions generate a warning on the SVG, but so what):
 ECM_ADD_APP_ICON(RKWard_Sources ICONS ${CMAKE_CURRENT_SOURCE_DIR}/icons/app-icon/sc-apps-rkward.svgz ${ICON_SRCS})
 ADD_EXECUTABLE(rkward ${RKWard_Sources})
 
diff --git a/rkward/windows/rktoplevelwindowgui.cpp b/rkward/windows/rktoplevelwindowgui.cpp
index 8103ce7d..81cb553b 100644
--- a/rkward/windows/rktoplevelwindowgui.cpp
+++ b/rkward/windows/rktoplevelwindowgui.cpp
@@ -108,7 +108,7 @@ RKTopLevelWindowGUI::RKTopLevelWindowGUI(KXmlGuiWindow *for_window) : QObject(fo
 	// Color scheme action. NOTE: selection is non-permanent for KF5 <= 5.87.0, auto-saved afterwards. Apparently, auto-save cannot be implemented for earlier versions within a few lines of code
 	KColorSchemeManager *manager = new KColorSchemeManager(this);
 #if KCONFIGWIDGETS_VERSION < QT_VERSION_CHECK(5, 67, 0)
-	actionCollection()->addAction(QStringLiteral("colorscheme_menu"), manager->createSchemeSelectionMenu(QString(), this))
+	actionCollection()->addAction(QStringLiteral("colorscheme_menu"), manager->createSchemeSelectionMenu(QString(), this));
 #else
 	actionCollection()->addAction(QStringLiteral("colorscheme_menu"), manager->createSchemeSelectionMenu(this));
 #endif


More information about the rkward-tracker mailing list