[education/rkward] /: documentation

[Thomas Friedrichsmeier]

Git commit 455992479d7cffaf62aab367a2c75a9d53e67dc0 by Thomas Friedrichsmeier.
Committed on 30/03/2022 at 20:38.
Pushed by tfry into branch 'master'.

documentation

M  +1    -0    ChangeLog
M  +1    -1    rkward/windows/rkhtmlwindow.cpp

https://invent.kde.org/education/rkward/commit/455992479d7cffaf62aab367a2c75a9d53e67dc0

diff --git a/ChangeLog b/ChangeLog
index 97e6f904..b7c7dc9b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,7 @@ TODOS for autotests:
   - Check and update the standards files
   - Use options(warn=1), in order to get warnings into the test?
 
+- Support for switching color themes, including basic support for dark theme
 - Fix crash in dev.capture()
 - Fix plot window not showing when created attached
 - Space-saving placement of main window status bar, and display more tips in it
diff --git a/rkward/windows/rkhtmlwindow.cpp b/rkward/windows/rkhtmlwindow.cpp
index f920c86e..2ccb3e1c 100644
--- a/rkward/windows/rkhtmlwindow.cpp
+++ b/rkward/windows/rkhtmlwindow.cpp
@@ -317,7 +317,7 @@ RKHTMLWindow::RKHTMLWindow (QWidget *parent, WindowMode mode) : RKMDIWindow (par
 	// See https://bugreports.qt.io/browse/QTBUG-89753
 	// Our CSS files try to support dark mode, automatically, but important versions of QWebEnginePage fail to honor the prefers-color-scheme selector
 	// To help those, apply the corresponding color values via javascript.
-	bool is_dark = (KColorScheme().background().color().lightnessF() < .5);
+	bool is_dark = (KColorScheme().background().color().lightnessF() < .5);  // <<- HACK to detect dark mode
 	if (is_dark) {
 		auto p = QWebEngineProfile::defaultProfile();
 		QWebEngineScript fix_color_scheme;