[education/rkward] /: Update documentation on supported library versions and commit policy.
Thomas Friedrichsmeier
null at kde.org
Mon Mar 28 15:20:50 BST 2022
Git commit d4b99918ec1131746f1dec235c3d5db21eea7e8c by Thomas Friedrichsmeier.
Committed on 28/03/2022 at 14:20.
Pushed by tfry into branch 'master'.
Update documentation on supported library versions and commit policy.
M +5 -8 CMakeLists.txt
M +7 -7 CommitPolicy.txt
https://invent.kde.org/education/rkward/commit/d4b99918ec1131746f1dec235c3d5db21eea7e8c
diff --git a/CMakeLists.txt b/CMakeLists.txt
index c610056a..5cb61bc6 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,9 +1,6 @@
PROJECT(rkward)
-CMAKE_MINIMUM_REQUIRED(VERSION 2.8.12) # As required by KF5
-IF(NOT "${CMAKE_VERSION}" VERSION_LESS 3.3.0)
- CMAKE_POLICY(SET CMP0063 NEW) # Shut up cmake warning
-ENDIF()
+CMAKE_MINIMUM_REQUIRED(VERSION 3.10.0)
IF(NOT CMAKE_VERBOSE_MAKEFILE)
SET (FORCE_PRETTY_MAKEFILE ON)
@@ -21,17 +18,17 @@ INCLUDE(ECMAddAppIcon)
INCLUDE(ECMMarkNonGuiExecutable)
INCLUDE(FeatureSummary)
-FIND_PACKAGE(Qt5 5.5 CONFIG REQUIRED COMPONENTS Widgets Core Xml Network Script PrintSupport)
-FIND_PACKAGE(KF5 5.2 REQUIRED COMPONENTS CoreAddons DocTools I18n XmlGui TextEditor WidgetsAddons Parts Config Notifications WindowSystem Archive OPTIONAL_COMPONENTS Crash)
+FIND_PACKAGE(Qt5 5.9 CONFIG REQUIRED COMPONENTS Widgets Core Xml Network Script PrintSupport)
+FIND_PACKAGE(KF5 5.44 REQUIRED COMPONENTS CoreAddons DocTools I18n XmlGui TextEditor WidgetsAddons Parts Config Notifications WindowSystem Archive OPTIONAL_COMPONENTS Crash)
IF(NOT NO_QT_WEBENGINE)
- FIND_PACKAGE(Qt5 5.5 OPTIONAL_COMPONENTS WebEngineWidgets)
+ FIND_PACKAGE(Qt5 5.9 OPTIONAL_COMPONENTS WebEngineWidgets)
IF(NOT Qt5WebEngineWidgets_FOUND OR Qt5WebEngineWidgets_VERSION VERSION_LESS "5.12.0")
MESSAGE(STATUS "QWebEngine not available (or version < 5.12). Falling back to QtWebKit")
SET(NO_QT_WEBENGINE 1)
ENDIF()
ENDIF(NOT NO_QT_WEBENGINE)
IF(NO_QT_WEBENGINE)
- FIND_PACKAGE(KF5 5.2 REQUIRED COMPONENTS WebKit)
+ FIND_PACKAGE(KF5 5.44 REQUIRED COMPONENTS WebKit)
ADD_DEFINITIONS(-DNO_QT_WEBENGINE) # TODO: rather set it for rkhtmlwindow, only
ELSE(NO_QT_WEBENGINE)
MESSAGE(STATUS "QtWebEngine will be used for rendering HTML. To use KF5WebKit, instead (if available), pass -DNO_QT_WEBENGINE=1 in your call to cmake.")
diff --git a/CommitPolicy.txt b/CommitPolicy.txt
index 3a7e8491..69f8309c 100644
--- a/CommitPolicy.txt
+++ b/CommitPolicy.txt
@@ -3,7 +3,7 @@ Committing to the RKWard repository
This is a very short guideline, primarily for those who have KDE developer access, and are wondering whether, and how to commit to the RKWard repository, directly.
-If you do not have KDE developer access, contact us on the mailing list (rkward-devel at kde.org), or submit patches via phabricator (see below).
+If you do not have KDE developer access, contact us on the mailing list (rkward-devel at kde.org), or submit patches invent.kde.org (see below).
Library dependencies
====================
@@ -11,10 +11,10 @@ Library dependencies
It is important to note that RKWard makes a point of _not_ requiring the latest KDE / QT libraries. If you want to use the latest and greatest, be sure to use #ifdef's, and make a best
effort to support features for older versions of libraries, too. For the moment, in the KF5 versions of RKWard, we're trying to support:
-Oldest library versions to support:
-* Qt: 5.2.1 (= Ubuntu Trusty)
-* KDE: 5.2.0 -- TODO: What version would be readily accessible for Trusty (if any)
-* R: 3.0.0? (= Ubuntu Trusty)
+Oldest library versions to support (= Ubuntu Bionic / 18.04; we generally try to support the two most recent LTS releases)
+* Qt: 5.9.5
+* KDE: 5.44.0
+* R: 3.4.4
Note: This is not set in stone, may change according to whatever is included in important distributions.
@@ -34,7 +34,7 @@ Branches and policies
For longer, experimental, or disruptive work, consider creating a branch named "devel/feature_description". Do let us know, when the feature is merged (or discarded), and the branch can be removed.
* work/*
The KDE git infrastructure special-cases branches under the prefix "work". Among other things these will allow history-rewrites, and will not produce commit notifications, i.e. the rules are much like for a personal fork.
- Most of the time, please use a "devel" branch (see above), instead of a "work" branch, as this allows better collaboration.
+ If you want other people to pariticipate on the branch, please use a "devel" branch (see above), instead of a "work" branch, as this allows better collaboration.
* kde4:
The latest KDE4 based development version of RKWard. There may or may not be future bugfix releases for KDE4, but no active development is expected on this branch.
@@ -52,4 +52,4 @@ and after your changes. If in any doubt, ask on the mailing list rkward-devel at kd
Review
======
-There is no strict policy on code reviews. It is never wrong to ask for review on Phabricator: https://phabricator.kde.org/differential/diff/create/ . Always select repository "RKward".
+There is no strict policy on code reviews. It is never wrong to ask for review on https://invent.kde.org/education/rkward
More information about the rkward-tracker
mailing list