[education/rkward] rkward/settings: Emit apply before calling applyChanges, so settings will sync before any extra action (i.e. setting the options in R for those modules that do)

Thomas Friedrichsmeier null at kde.org
Sat Mar 19 23:17:44 GMT 2022


Git commit 25b32111f73b6a45fa356ce1626e6e02f56e8fcc by Thomas Friedrichsmeier.
Committed on 19/03/2022 at 22:13.
Pushed by tfry into branch 'master'.

Emit apply before calling applyChanges, so settings will sync before any extra action (i.e. setting the options in R for those modules that do)

M  +1    -1    rkward/settings/rksettingsmodule.h

https://invent.kde.org/education/rkward/commit/25b32111f73b6a45fa356ce1626e6e02f56e8fcc

diff --git a/rkward/settings/rksettingsmodule.h b/rkward/settings/rksettingsmodule.h
index 4075ca20..5598a6bb 100644
--- a/rkward/settings/rksettingsmodule.h
+++ b/rkward/settings/rksettingsmodule.h
@@ -147,8 +147,8 @@ protected:
 	bool changed;
 /** temporary indirection until applyChanges() has been obsolete, everywhere */
 	void doApply() {
-		applyChanges();
 		emit(apply());
+		applyChanges();
 		changed = false;
 	}
 };



More information about the rkward-tracker mailing list