[education/rkward] rkward: Add yet more debug code around backend startup

Thomas Friedrichsmeier null at kde.org
Sun Jul 31 12:11:37 BST 2022


Git commit 0b91a0d22dc75a783c0260da59c3cb2e6f0b0aff by Thomas Friedrichsmeier.
Committed on 31/07/2022 at 11:11.
Pushed by tfry into branch 'master'.

Add yet more debug code around backend startup

M  +2    -0    rkward/rbackend/rkfrontendtransmitter.cpp
M  +1    -3    rkward/settings/rkrecenturls.cpp

https://invent.kde.org/education/rkward/commit/0b91a0d22dc75a783c0260da59c3cb2e6f0b0aff

diff --git a/rkward/rbackend/rkfrontendtransmitter.cpp b/rkward/rbackend/rkfrontendtransmitter.cpp
index 6210023b..2ef4a788 100644
--- a/rkward/rbackend/rkfrontendtransmitter.cpp
+++ b/rkward/rbackend/rkfrontendtransmitter.cpp
@@ -141,6 +141,7 @@ void RKFrontendTransmitter::run () {
 	dummy.waitForFinished();
 	dummy.readAllStandardOutput();
 #endif
+	RK_DEBUG(RBACKEND, DL_DEBUG, "Starting backend. Timestamp %d", QDateTime::currentMSecsSinceEpoch(), token.length());
 	backend->start(RKSessionVars::RBinary(), args, QIODevice::ReadOnly);
 
 	if (!backend->waitForStarted()) {
@@ -150,6 +151,7 @@ void RKFrontendTransmitter::run () {
 		backend->closeReadChannel(QProcess::StandardError);
 		backend->closeReadChannel(QProcess::StandardOutput);
 	}
+	RK_DEBUG(RBACKEND, DL_DEBUG, "Startup done at %d. Received token length was %d", QDateTime::currentMSecsSinceEpoch(), token.length());
 
 	exec ();
 
diff --git a/rkward/settings/rkrecenturls.cpp b/rkward/settings/rkrecenturls.cpp
index e3f6fc41..c9d59cda 100644
--- a/rkward/settings/rkrecenturls.cpp
+++ b/rkward/settings/rkrecenturls.cpp
@@ -106,9 +106,7 @@ void RKRecentUrls::saveConfig() {
 
 KRecentFilesAction* RKRecentUrls::claimAction(const QString& id) {
 	RK_TRACE(SETTINGS);
-	auto ret = action(id);
-	RK_ASSERT(!ret->parent());
-	return ret;
+	return action(id);
 }
 
 KRecentFilesAction * RKRecentUrls::action(const QString& id) {


More information about the rkward-tracker mailing list