[education/rkward] rkward/plugins/analysis/irt/tests: Fix mis-quoting of selected columns

Thomas Friedrichsmeier null at kde.org
Thu Jul 28 13:45:38 BST 2022


Git commit c25922ce23c3381fd31878332a5338c889a0634b by Thomas Friedrichsmeier.
Committed on 28/07/2022 at 12:45.
Pushed by tfry into branch 'master'.

Fix mis-quoting of selected columns

M  +2    -8    rkward/plugins/analysis/irt/tests/ltm_cronbach_alpha.js

https://invent.kde.org/education/rkward/commit/c25922ce23c3381fd31878332a5338c889a0634b

diff --git a/rkward/plugins/analysis/irt/tests/ltm_cronbach_alpha.js b/rkward/plugins/analysis/irt/tests/ltm_cronbach_alpha.js
index 8322524c..a898e8c4 100644
--- a/rkward/plugins/analysis/irt/tests/ltm_cronbach_alpha.js
+++ b/rkward/plugins/analysis/irt/tests/ltm_cronbach_alpha.js
@@ -7,15 +7,12 @@ function calculate () {
 	// let's read all values into php variables for the sake of readable code
 	var data            = getValue("x");
 	var chk_select      = getValue("chk_select");
-	var inp_items       = getValue("inp_items");
+	var inp_items       = getList("inp_items.shortname").map(quote).join(', ');
 	var spin_samples    = getValue("spin_samples");
 	var chk_standard    = getValue("chk_standard");
 	var chk_na          = getValue("chk_na");
 	var chk_bsci        = getValue("chk_bsci");
 	var spin_ci         = getValue("spin_ci");
-	// reformat inp_items
-	if (inp_items)
-		inp_items   = inp_items.replace(/\n/g,', ').replace(/(\w*)\[\[|\]\]/g, '');
 
 	///////////////////////////////////
 	// check for selected options
@@ -60,10 +57,7 @@ function printout (is_preview) {
 	var chk_na          = getValue("chk_na");
 	var chk_bsci        = getValue("chk_bsci");
 	var spin_ci         = getValue("spin_ci");
-	var inp_items       = getValue("inp_items");
-	// reformat inp_items
-	if (inp_items)
-		inp_items   = inp_items.replace(/\n/g,', ').replace(/(\w*)\[\["|"\]\]/g, '');
+	var inp_items       = getList("inp_items.shortname").map(quote).join(', ');
 
 	if (!is_preview) {
 		header = new Header (i18n ("Cronbach\'s alpha")).add (i18n ("Dataset"), getValue ("x"));


More information about the rkward-tracker mailing list