[education/rkward] /: current_filename property needs to be marked internal, as it is not user settable

Thomas Friedrichsmeier null at kde.org
Sun Apr 10 12:27:03 BST 2022


Git commit d1361e8ac8daffb24a25caa8ad3260f9d513bb8d by Thomas Friedrichsmeier.
Committed on 10/04/2022 at 11:26.
Pushed by tfry into branch 'master'.

current_filename property needs to be marked internal, as it is not user settable

M  +3    -3    rkward/plugin/rkstandardcomponent.cpp
M  +1    -1    tests/data_plugin_tests/recode_categorical.messages.txt

https://invent.kde.org/education/rkward/commit/d1361e8ac8daffb24a25caa8ad3260f9d513bb8d

diff --git a/rkward/plugin/rkstandardcomponent.cpp b/rkward/plugin/rkstandardcomponent.cpp
index 176b655c..f321dcd3 100644
--- a/rkward/plugin/rkstandardcomponent.cpp
+++ b/rkward/plugin/rkstandardcomponent.cpp
@@ -71,9 +71,9 @@ RKStandardComponent::RKStandardComponent (RKComponent *parent_component, QWidget
 	RKComponentPropertyRObjects *current_object_property = new RKComponentPropertyRObjects (this, false);
 	RKComponentPropertyRObjects *current_dataframe_property = new RKComponentPropertyRObjects (this, false);
 	RKComponentPropertyBase *current_filename_property = new RKComponentPropertyBase (this, false);
-	current_object_property->setInternal (true);
-	current_dataframe_property->setInternal (true);
-	current_filename_property->setInternal (false);
+	current_object_property->setInternal(true);
+	current_dataframe_property->setInternal(true);
+	current_filename_property->setInternal(true);
 	RKMDIWindow *w = RKWorkplace::mainWorkplace ()->activeWindow (RKMDIWindow::AnyWindowState);
 	if (w) {
 		current_object_property->setValue (w->globalContextProperty ("current_object"));
diff --git a/tests/data_plugin_tests/recode_categorical.messages.txt b/tests/data_plugin_tests/recode_categorical.messages.txt
index 4f62f4ad..18c54263 100644
--- a/tests/data_plugin_tests/recode_categorical.messages.txt
+++ b/tests/data_plugin_tests/recode_categorical.messages.txt
@@ -1,2 +1,2 @@
-Warning in eval(expr, envir, enclos) :
+Warning in eval(quote({ :
   Some input values were specified more than once: "9", "10"


More information about the rkward-tracker mailing list