[rkward] rkward: Debug message, move comments.

Thomas Friedrichsmeier null at kde.org
Sun Mar 29 12:20:50 BST 2020


Git commit e9878d4a7a04bc3583f48285478c4b415739dfc7 by Thomas Friedrichsmeier.
Committed on 29/03/2020 at 11:20.
Pushed by tfry into branch 'master'.

Debug message, move comments.

M  +4    -0    rkward/rkward.cpp
M  +1    -5    rkward/windows/katepluginintegration.cpp

https://commits.kde.org/rkward/e9878d4a7a04bc3583f48285478c4b415739dfc7

diff --git a/rkward/rkward.cpp b/rkward/rkward.cpp
index 86d02d45..cfa49ffa 100644
--- a/rkward/rkward.cpp
+++ b/rkward/rkward.cpp
@@ -160,6 +160,10 @@ RKWardMainWindow::RKWardMainWindow () : KParts::MainWindow ((QWidget *)0, (Qt::W
 	// This is pretty convoluted, but while loading plugins the katePluginIntegration-client may gain new actions and thus needs
 	// to be reloaded. We cannot - currently, KF5.65 - delay loading the UI defintion(s), because plugins rely on it having a GUI factory.
 	katePluginIntegration ()->loadPlugins (RKSettingsModuleKatePlugins::pluginsToLoad ());
+// TODO: initToolWindowActions() should be called after all plugins are loaded (and have registered their tool views). However
+//       that may be a problem, if there is no KXMLGUIFactory around, yet. So, annoyingly, we need to create the GUI, before we
+//       have everything to populate it. Therefore, after init, the client is removed and re-added in order to trigger a UI
+//       refresh.
 	toplevel_actions->initToolWindowActions ();
 	factory()->removeClient (toplevel_actions);
 	factory()->addClient (toplevel_actions);
diff --git a/rkward/windows/katepluginintegration.cpp b/rkward/windows/katepluginintegration.cpp
index b8f38c08..7179baf6 100644
--- a/rkward/windows/katepluginintegration.cpp
+++ b/rkward/windows/katepluginintegration.cpp
@@ -579,14 +579,10 @@ void KatePluginIntegrationWindow::catchXMLGUIClientsHack(KXMLGUIClient* client)
 		RK_ASSERT(plugin_resources.contains(active_plugin));
 		plugin_resources[active_plugin].clients.append(client);
 	} else {
-		RK_DEBUG(APP, DL_DEBUG, "XML client created by unknown kate plugin");
+		RK_DEBUG(APP, DL_INFO, "XML client created by unknown kate plugin");
 	}
 }
 
-// TODO: new RKToplevelWindowGUI should be called after all plugins are loaded (and have registered their tool views). However
-//       that may be a problem, if there is no KXMLGUIFactory around, yet. So, annoyingly, we need to create the GUI, before we
-//       have everything to populate it.
-
 ///  END  KTextEditor::MainWindow interface
 
 #include "katepluginintegration.moc"



More information about the rkward-tracker mailing list