[rkward] rkward/dialogs: Make sure to properly quote+escape libloc path. It may contain backslashes on Windows.

Thomas Friedrichsmeier null at kde.org
Wed May 16 09:48:41 UTC 2018


Git commit 5766967b7fd99a64c5d459c16025cd09cb6c3fae by Thomas Friedrichsmeier.
Committed on 16/05/2018 at 09:48.
Pushed by tfry into branch 'master'.

Make sure to properly quote+escape libloc path. It may contain backslashes on Windows.

M  +1    -1    rkward/dialogs/rkloadlibsdialog.cpp

https://commits.kde.org/rkward/5766967b7fd99a64c5d459c16025cd09cb6c3fae

diff --git a/rkward/dialogs/rkloadlibsdialog.cpp b/rkward/dialogs/rkloadlibsdialog.cpp
index ca807b2a..0db6f7ac 100644
--- a/rkward/dialogs/rkloadlibsdialog.cpp
+++ b/rkward/dialogs/rkloadlibsdialog.cpp
@@ -294,7 +294,7 @@ bool RKLoadLibsDialog::installPackages (const QStringList &packages, QString to_
 
 	addLibraryLocation (to_libloc);
 
-	QString command_string = "install.packages (c (\"" + packages.join ("\", \"") + "\")" + ", lib=\"" + to_libloc + "\"";
+	QString command_string = "install.packages (c (\"" + packages.join ("\", \"") + "\")" + ", lib=" + RObject::rQuote (to_libloc);
 	QString downloaddir = QDir (RKSettingsModuleGeneral::filesPath ()).filePath ("package_archive");
 	if (RKSettingsModuleRPackages::archivePackages ()) {
 		QDir (RKSettingsModuleGeneral::filesPath ()).mkdir ("package_archive");



More information about the rkward-tracker mailing list