[rkward] packages/rkwarddev: fixed rk.XML.connect.R

m.eik michalke meik.michalke at uni-duesseldorf.de
Tue Oct 6 21:22:57 UTC 2015


Git commit f6db51cfbea4c4a9ee837a104860528807639247 by m.eik michalke.
Committed on 06/10/2015 at 21:19.
Pushed by meikm into branch 'master'.

fixed rk.XML.connect.R

  - the function "forgot" to add the modifier to the governor if it wasn't a XiMpLe node

M  +3    -1    packages/rkwarddev/ChangeLog
M  +3    -1    packages/rkwarddev/R/rk.XML.connect.R

http://commits.kde.org/rkward/f6db51cfbea4c4a9ee837a104860528807639247

diff --git a/packages/rkwarddev/ChangeLog b/packages/rkwarddev/ChangeLog
index 0609b09..1391b24 100644
--- a/packages/rkwarddev/ChangeLog
+++ b/packages/rkwarddev/ChangeLog
@@ -1,10 +1,12 @@
 ChangeLog for package rkwarddev
 
-changes in version 0.07-4 (2015-10-04)
+changes in version 0.07-4 (2015-10-06)
 unreleased:
   - this version is under development
 fixed:
   - attribute "max_precision" in <spinbox> was misspelled
+  - rk.XML.connect() still handled modifiers for "governor" wrong if it wasn't
+    a XiMpLe node
 added:
   - new methods plugin2script() to try to translate raw plugin XML
     into working rkwarddev script calls
diff --git a/packages/rkwarddev/R/rk.XML.connect.R b/packages/rkwarddev/R/rk.XML.connect.R
index 7a9558f..9d5a998 100644
--- a/packages/rkwarddev/R/rk.XML.connect.R
+++ b/packages/rkwarddev/R/rk.XML.connect.R
@@ -71,7 +71,9 @@ rk.XML.connect <- function(governor, client, get="state", set="enabled", not=FAL
       } else {}
     } else {}
   } else {
-    modif.validity("all", modifier=get)
+    if(modif.validity("all", modifier=get)){
+      governor.id <- paste(governor.id, get, sep=".")
+    } else {}
   }
   if(isTRUE(not)){
     governor.id <- paste(governor.id, "not", sep=".")



More information about the rkward-tracker mailing list