[rkward/frameworks] /: Fix some broken connects. And I had thought, these would be compile-time errors, now...

Thomas Friedrichsmeier thomas.friedrichsmeier at ruhr-uni-bochum.de
Thu Nov 26 09:50:56 UTC 2015


Git commit ff52262f0299b788fda3a1ca1b4c4820d7c0099d by Thomas Friedrichsmeier.
Committed on 26/11/2015 at 09:50.
Pushed by tfry into branch 'frameworks'.

Fix some broken connects. And I had thought, these would be compile-time errors, now...

M  +1    -0    TODO
M  +1    -1    rkward/misc/rkdynamicsearchline.cpp
M  +1    -1    rkward/windows/rkworkplaceview.cpp

http://commits.kde.org/rkward/ff52262f0299b788fda3a1ca1b4c4820d7c0099d

diff --git a/TODO b/TODO
index ee92f3a..825f7d7 100644
--- a/TODO
+++ b/TODO
@@ -6,6 +6,7 @@ KF5 port:
 Things to do:
 - Remove kde4libssupport classes
 - Adjust platform checks
+- Since the conversion from KIcon to QIcon, there is crash on exit, sometimes. Google turns up this: https://github.com/OtterBrowser/otter-browser/issues/889
 - Device window embedding / remove qwinhost
 Things to test at the end:
 - Everthing concerning loading / saving, from recent files, scripts, workspace, etc.
diff --git a/rkward/misc/rkdynamicsearchline.cpp b/rkward/misc/rkdynamicsearchline.cpp
index ce2c7c1..f5fae0e 100644
--- a/rkward/misc/rkdynamicsearchline.cpp
+++ b/rkward/misc/rkdynamicsearchline.cpp
@@ -30,7 +30,7 @@ RKDynamicSearchLine::RKDynamicSearchLine (QWidget *parent) : KLineEdit (parent)
 	setClickMessage (i18n ("Search"));
 	timer.setSingleShot (true);
 	connect (&timer, &QTimer::timeout, this, &RKDynamicSearchLine::delayedSearch);
-	connect (this, &RKDynamicSearchLine::textChanged, this, &RKDynamicSearchLine::textChanged);
+	connect (this, &QLineEdit::textChanged, this, &RKDynamicSearchLine::textChanged);
 }
 
 RKDynamicSearchLine::~RKDynamicSearchLine () {
diff --git a/rkward/windows/rkworkplaceview.cpp b/rkward/windows/rkworkplaceview.cpp
index e0aa33b..bbfbe10 100644
--- a/rkward/windows/rkworkplaceview.cpp
+++ b/rkward/windows/rkworkplaceview.cpp
@@ -59,7 +59,7 @@ RKWorkplaceView::RKWorkplaceView (QWidget *parent) : KTabWidget (parent) {
 
 	KAcceleratorManager::setNoAccel (tabBar ());	// TODO: This is a WORKAROUND for a bug in kdelibs where tabs named "a0.txt", "a1.txt", etc. will steal the Alt+0/1... shortcuts
 	setTabBarHidden (true);		// initially
-	connect (this, &RKWorkplaceView::currentChanged, this, &RKWorkplaceView::currentPageChanged);
+	connect (this, &QTabWidget::currentChanged, this, &RKWorkplaceView::currentPageChanged);
 }
 
 RKWorkplaceView::~RKWorkplaceView () {



More information about the rkward-tracker mailing list