[rkward-cvs] SF.net SVN: rkward-code:[4510] trunk/rkward

tfry at users.sf.net tfry at users.sf.net
Sun Jan 27 17:17:48 UTC 2013


Revision: 4510
          http://sourceforge.net/p/rkward/code/4510
Author:   tfry
Date:     2013-01-27 17:17:47 +0000 (Sun, 27 Jan 2013)
Log Message:
-----------
In light of today's discussion on ordering issues, insert default pluginmap at the start, not end, if it is missing.

Modified Paths:
--------------
    trunk/rkward/ChangeLog
    trunk/rkward/rkward/settings/rksettingsmoduleplugins.cpp

Modified: trunk/rkward/ChangeLog
===================================================================
--- trunk/rkward/ChangeLog	2013-01-27 16:08:59 UTC (rev 4509)
+++ trunk/rkward/ChangeLog	2013-01-27 17:17:47 UTC (rev 4510)
@@ -6,6 +6,7 @@
 	- TODO:
 		- Provide more info (particularly about data) in selection UI
 		- Explicitly document the fact that <include>s can be used for <about> and <dependencies>
+		- Fix duplicate trigger of pluginmap loading when clicking "ok" on settings dialog
 		- Add possibilities for soft dependencies (i.e. dynamic version check within a plugin)
 		- Think about means for cross-package pluginmap includes
 - Added support for the upcoming R 3.0.0			TODO: Check for any more regressions, before release

Modified: trunk/rkward/rkward/settings/rksettingsmoduleplugins.cpp
===================================================================
--- trunk/rkward/rkward/settings/rksettingsmoduleplugins.cpp	2013-01-27 16:08:59 UTC (rev 4509)
+++ trunk/rkward/rkward/settings/rksettingsmoduleplugins.cpp	2013-01-27 17:17:47 UTC (rev 4510)
@@ -316,8 +316,8 @@
 	// make sure the default plugin map is in the list (unless it is non-readable)
 	if ((default_pluginmap_index < 0) && (default_pluginmap.isReadable ())) {
 		PluginMapStoredInfo inf (default_pluginmap.absoluteFilePath ());
-		known_plugin_maps.append (inf);
-		default_pluginmap_index = known_plugin_maps.size () - 1;
+		known_plugin_maps.prepend (inf);
+		default_pluginmap_index = 0;
 	}
 
 	// if no other pluginmap is active, activate the default map





More information about the rkward-tracker mailing list