[rkward-tracker] [ rkward-Bugs-3404013 ] FIXED IN SVN: Expand dialogs when showing code

[SourceForge.net]

Bugs item #3404013, was opened at 2011-09-04 15:33
Message generated for change (Settings changed) made by tfry
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=459007&aid=3404013&group_id=50231

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: user interface
Group: None
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Milan Bouchet-Valat (nalimilan)
Assigned to: Nobody/Anonymous (nobody)
Summary: FIXED IN SVN: Expand dialogs when showing code

Initial Comment:
So, with recent versions dialogs are correclty sized by default, which is great. But if you click on the "Code" button, you still only see one line of the multi-line entry (and that line is blank). The dialog should really resize to something reasonable, I suggest the dialog expands to the bottom of the screen in all cases, since people clicking on "Code" probably want to read that code correctly (even if it hides the main window). Clicking on "Code" again should resize the window to the original size.

(I think I read in planet.gnome.org recently that all common window managers force the window height to the screen size if you ask for something too big, so you probably can just request 1000px or so.)

----------------------------------------------------------------------

Comment By: Milan Bouchet-Valat (nalimilan)
Date: 2011-09-14 10:46

Message:
No problem, that's OK with me too.Thanks!

I would say you don't need a setting to allow users to change this value,
but that's probably a GNOMEr POV. ;-)

----------------------------------------------------------------------

Comment By: Thomas Friedrichsmeier (tfry)
Date: 2011-09-14 09:26

Message:
Hi!

Actually, the dialog _is_ resized when clicking on the code button. And in
fact, the amount by which it is resized (i.e. the height of the code
display) can be configured at Settings->Configure RKWard->Plugins. However,
in fact, the default value for that was set to an unreasonably small 40px.
I have now adjusted that to 250px in the development version.

Using a fixed (initial) height of the code display may not be a terribly
elegant solution. However, getting this right is not as easy as it may
seem. Among other things:
- The layout should be sane, whether or not the code display is shown
initially (a configurable option).
- Toggling the code display should work well, whether the dialog is placed
near the top or the bottom of the screen.
- When toggling, the layout of the upper portion of the dialog should not
jump too much.
- The dialog should react well to user resizing, whether or not the code
display is shown.
- Should work well on a large variety of screen resolutions.

Well, I don't claim the current solution is the best possible one, but a
good deal of trial and error preceded it. Thus, to me, this is a mix of
"fixed" (default size setting) and "won't fix". Of course, if you can
provide a patch that "just works", I'll be more than happy to apply it
(main function to look at is RKStandardComponentGUI::toggleCode()).

Regards
Thomas

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=459007&aid=3404013&group_id=50231