[rkward-cvs] SF.net SVN: rkward:[4019] trunk/rkward

[tfry at users.sourceforge.net]

Revision: 4019
          http://rkward.svn.sourceforge.net/rkward/?rev=4019&view=rev
Author:   tfry
Date:     2011-11-06 19:08:30 +0000 (Sun, 06 Nov 2011)
Log Message:
-----------
Fix one above boundary bug.

Modified Paths:
--------------
    trunk/rkward/ChangeLog
    trunk/rkward/rkward/dialogs/rkloadlibsdialog.cpp

Modified: trunk/rkward/ChangeLog
===================================================================
--- trunk/rkward/ChangeLog	2011-11-06 13:10:15 UTC (rev 4018)
+++ trunk/rkward/ChangeLog	2011-11-06 19:08:30 UTC (rev 4019)
@@ -1,3 +1,5 @@
+- Fixed: potential crash when clicking "Select all updates" in the package installation dialog
+- Fixed: potential crash in object name completion under certain conditions
 - Simplified the "Sort Data" plugin, and added a help page
 - Fixed: On Windows, detached windows would sometimes be positioned with the menubar outside the upper screen edge
 - Add GUI support for inspecting the call stack during debugging

Modified: trunk/rkward/rkward/dialogs/rkloadlibsdialog.cpp
===================================================================
--- trunk/rkward/rkward/dialogs/rkloadlibsdialog.cpp	2011-11-06 13:10:15 UTC (rev 4018)
+++ trunk/rkward/rkward/dialogs/rkloadlibsdialog.cpp	2011-11-06 19:08:30 UTC (rev 4019)
@@ -825,7 +825,7 @@
 	RK_TRACE (DIALOGS);
 
 	// inefficient, but so what...
-	for (int i = updateable_packages_in_installed.count (); i >= 0; --i) {
+	for (int i = updateable_packages_in_installed.count () - 1; i >= 0; --i) {
 		markPackageForInstallation (installed_packages[updateable_packages_in_installed[i]]);
 	}
 	return index (UpdateablePackages, 0, QModelIndex ());

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.