[rkward-cvs] SF.net SVN: rkward:[3542] trunk/rkward

[tfry at users.sourceforge.net]

Revision: 3542
          http://rkward.svn.sourceforge.net/rkward/?rev=3542&view=rev
Author:   tfry
Date:     2011-05-10 11:14:00 +0000 (Tue, 10 May 2011)

Log Message:
-----------
Deal with buggy 'native' system file dialogs better.

Modified Paths:
--------------
    trunk/rkward/ChangeLog
    trunk/rkward/rkward/rkward.bat.template
    trunk/rkward/rkward/rkward.cpp

Modified: trunk/rkward/ChangeLog
===================================================================
--- trunk/rkward/ChangeLog	2011-05-09 07:30:49 UTC (rev 3541)
+++ trunk/rkward/ChangeLog	2011-05-10 11:14:00 UTC (rev 3542)
@@ -1,3 +1,4 @@
+- On Windows, RKWard will detect, and offer to disable "native" file system dialogs
 - Object browsers that show only the global environment now hide the ".GlobalEnv" item
 - Fixed: Function argument hints would not be shown in some corner cases
 - Added function rk.print.code() to write highlighted R code to the output window		# TODO: Next, implement the 'carbon copy' feature

Modified: trunk/rkward/rkward/rkward.bat.template
===================================================================
--- trunk/rkward/rkward/rkward.bat.template	2011-05-09 07:30:49 UTC (rev 3541)
+++ trunk/rkward/rkward/rkward.bat.template	2011-05-10 11:14:00 UTC (rev 3542)
@@ -15,7 +15,7 @@
 %~dsp0\kdeinit4.exe
 
 ECHO Starting RKWard
-SET RKWARD.BIN=%~dsp0\..\lib\kde4\libexec\rkward.frontend.exe
+SET RKWARD.BIN=%~dsp0\rkward.frontend.exe
 SET RKWARD_ENSURE_PREFIX=%~dsp0\..
 SET DEBUGGER=
 

Modified: trunk/rkward/rkward/rkward.cpp
===================================================================
--- trunk/rkward/rkward/rkward.cpp	2011-05-09 07:30:49 UTC (rev 3541)
+++ trunk/rkward/rkward/rkward.cpp	2011-05-10 11:14:00 UTC (rev 3542)
@@ -206,6 +206,18 @@
 	gui_rebuild_locked = false;
 
 	show ();
+#ifdef Q_WS_WIN
+	// detect and disable the buggy "native" file dialogs
+	KConfigGroup cg = KGlobal::config ().data ()->group ("KFileDialog Settings");
+	if (cg.readEntry ("Native", true)) {
+		int res = KMessageBox::questionYesNo (this, i18n ("Your installation of KDE is configured to use \"native\" file dialogs. This is known to cause issues in some cases, and we recommend to disable \"native\" file dialogs.\nShould \"native\" file dialogs be disabled in RKWard?"),
+							i18n ("Potential problem with your configuration"), KGuiItem (i18n ("Yes, disable")), KGuiItem (i18n ("No, use \"native\" file dialogs")), "windows_native_kfiledialog");
+		if (res != KMessageBox::No) {
+			cg.writeEntry ("Native", false);
+			cg.sync ();
+		}
+	}
+#endif
 
 	KUrl recover_url = RKRecoverDialog::checkRecoverCrashedWorkspace ();
 	if (!recover_url.isEmpty ()) open_url = recover_url;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.