[rkward-cvs] SF.net SVN: rkward:[4079] trunk/rkward

[tfry at users.sourceforge.net]

Revision: 4079
          http://rkward.svn.sourceforge.net/rkward/?rev=4079&view=rev
Author:   tfry
Date:     2011-12-07 18:30:29 +0000 (Wed, 07 Dec 2011)
Log Message:
-----------
Another small clean up, and no need to beep.

Modified Paths:
--------------
    trunk/rkward/ChangeLog
    trunk/rkward/rkward/rkconsole.cpp

Modified: trunk/rkward/ChangeLog
===================================================================
--- trunk/rkward/ChangeLog	2011-12-07 18:16:45 UTC (rev 4078)
+++ trunk/rkward/ChangeLog	2011-12-07 18:30:29 UTC (rev 4079)
@@ -1,3 +1,4 @@
+- Improve keypress handling issues in the R Console, when the cursor or a selection is outside the editable range
 - Fixed: Failure to open workspaces with non-latin1 filenames from the command line
 - Fixed: Saving / restoring workplace layout would fail when saving to directories with unusual characters
 - Only install translations which are at least 80% complete (not counting strings in plugins, which are not yet translatable)

Modified: trunk/rkward/rkward/rkconsole.cpp
===================================================================
--- trunk/rkward/rkward/rkconsole.cpp	2011-12-07 18:16:45 UTC (rev 4078)
+++ trunk/rkward/rkward/rkconsole.cpp	2011-12-07 18:30:29 UTC (rev 4079)
@@ -214,13 +214,9 @@
 		KTextEditor::Range selrange = view->selectionRange ();
 		if (selrange.start ().line () < (doc->lines () - 1) || selrange.start ().column () < prefix.length ()) {
 			// There is a selection outside the command line
-			// If it's a modifier key, that's quite ok. Otherwise, we need to take off the selection, before handling the key press
-			if (!is_modifier_key) {
-				KApplication::kApplication ()->beep ();
-				view->setSelection (KTextEditor::Range ());
-			} else {
-				return true;
-			}
+			// If it's a modifier key, that's quite ok. Otherwise, we need to take off the selection, then proceed to handling the key press
+			if (is_modifier_key) return true;
+			view->setSelection (KTextEditor::Range ());
 		}
 	}
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.